<div dir="ltr"><div dir="ltr">On Mon, Jan 24, 2022 at 1:01 PM Fāng-ruì Sòng <<a href="mailto:maskray@google.com">maskray@google.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Mon, Jan 24, 2022 at 12:41 PM Stephen Hines <<a href="mailto:srhines@google.com" target="_blank">srhines@google.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Heh, I actually just moved the Android platform build to DWARFv5 last week (<a href="https://android-review.googlesource.com/c/platform/build/soong/+/1954424" target="_blank">https://android-review.googlesource.com/c/platform/build/soong/+/1954424</a>). We had previously tried this but had to revert it due to some issues with libabigail. I'll move upstream LLVM to default to DWARFv5 for Android more generally soon. Thanks for reminding me to do so.</div></blockquote><div><br></div><div>Thanks for making platforms more aligned with the modern standard :)  </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div>Thanks,</div><div>Steve</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jan 23, 2022 at 8:52 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Well, made the switch to DWARFv5 by default in d3b26dea16108c427b19b5480c9edc76edf8f5b4 and included a change to keep DWARFv4 as the default for linux-androideabi (at least I think I made that change in the right place). If it needs to be more generic (apply to non-linux toolchains, but I don't think so?) or can be removed because Android's OK with DWARFv5 - should be simple to make that change.</div></blockquote></div></blockquote><div><br></div><div>Congratulations to the switch!</div><div><br></div><div>(I was thinking whether we'd need a CMake variable, hopefully we won't need it.)</div></div></div></blockquote><div><br>Yeah, *fingers crossed* Few curious things in compiler-rt tests I need to followup on.<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jan 23, 2022 at 8:08 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hey Stephen,<br><br>I see you added a test to ensure Android uses DWARFv4 here:  <a href="https://reviews.llvm.org/D60238" target="_blank">https://reviews.llvm.org/D60238</a><br><br>Is that still the case? I can figure out how to ensure that's the case as we transition the default to DWARFv5 for platforms that haven't opted out.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Nov 30, 2021 at 9:28 AM Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Nov 30, 2021 at 9:10 AM via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<br>
><br>
> > Generic_GCC has many (indirect) derived classes<br>
> > (FreeBSD/OpenBSD/Solaris) which override the base<br>
> > GetDefaultDwarfVersion().<br>
> > The Generic_GCC change will affect<br>
> > Haiku/Hurd/Linux/NetBSD/PS4CPU/etc. I have CC'd these folks: if<br>
> > your platform is not ready for DWARF v5, you can override<br>
> > GetDefaultDwarfVersion() in your toolchain.<br>
<br>
We have been using v5 in yocto with clang13 onwards as well [1] and<br>
have not seen any blockers.<br>
<br>
[1] <a href="https://github.com/kraj/meta-clang/blob/master/recipes-devtools/clang/clang/0027-clang-Switch-defaults-to-dwarf-5-debug-info-on-Linux.patch" rel="noreferrer" target="_blank">https://github.com/kraj/meta-clang/blob/master/recipes-devtools/clang/clang/0027-clang-Switch-defaults-to-dwarf-5-debug-info-on-Linux.patch</a><br>
<br>
><br>
> PS4 updated to set v4 explicitly as of<br>
> <a href="https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db</a><br>
> --paulr<br>
> _______________________________________________<br>
> cfe-dev mailing list<br>
> <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr">宋方睿</div></div></div>
</blockquote></div></div>