<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Lucida Sans Unicode";
panose-1:2 11 6 2 3 5 4 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Some naming violations are deliberate; this is particularly true in llvm/include/ADT, where many classes define methods that intentionally follow the snake_case conventions used by STL. Those should not be changed.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">You should feel empowered to update the conventions for code you are working on for other reasons (as separate NFC changes and not requiring a pre-commit review). But going through the entire project to update the conventions would probably
be viewed as unnecessary churn, and potentially making life more difficult for people working on those areas.<o:p></o:p></p>
<p class="MsoNormal">--paulr<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> cfe-dev <cfe-dev-bounces@lists.llvm.org> <b>On Behalf Of
</b>Craig Topper via cfe-dev<br>
<b>Sent:</b> Tuesday, January 11, 2022 6:21 PM<br>
<b>To:</b> clang developer list <cfe-dev@lists.llvm.org>; Richard <legalize@xmission.com><br>
<b>Subject:</b> Re: [cfe-dev] Identifier naming inconsistencies in clang<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">The coding guidelines here <a href="https://urldefense.com/v3/__https:/llvm.org/docs/CodingStandards.html*introduction__;Iw!!JmoZiZGBv3RvKRSx!plX2V6Sh1Q1DDcjU0neKw87KXeMaAMufGIhGCZ5exEQu11bFNeBxI6RgKpJ-EmSwWw$">https://llvm.org/docs/CodingStandards.html#introduction</a>
say<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">"<span style="font-size:10.5pt;font-family:"Lucida Sans Unicode",sans-serif;color:black">There are some conventions that are not uniformly followed in the code base (e.g. the naming convention). This is because they are relatively new,
and a lot of code was written before they were put in place. Our long term goal is for the entire codebase to follow the convention, but we explicitly <em><span style="font-family:"Lucida Sans Unicode",sans-serif">do not</span></em> want patches that do large-scale
reformatting of existing code. On the other hand, it is reasonable to rename the methods of a class if you’re about to change it in some other way. Please commit such changes separately to make code review easier."</span><o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">But it has said that for a long time so I don't know what the feeling is these days.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><br clear="all">
<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">~Craig<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Tue, Jan 11, 2022 at 3:17 PM Richard via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Hi Team,<br>
<br>
So... my IDE has settings to recognize identifier naming conventions<br>
and it's constantly flagging various bits of clang code as not<br>
following the convention, typically:<br>
<br>
- Methods/functions that don't begin with lower-case letter<br>
- Variables that don't begin with upper-case character<br>
- Occasionally methods/variables using underscores as word separators<br>
<br>
Is it acceptable to submit NFC refactoring changes that address the<br>
inconsistencies or does it require a phabricator review?<br>
<br>
Thanks,<br>
<br>
-- Richard<br>
<br>
-- <br>
"The Direct3D Graphics Pipeline" free book <<a href="https://urldefense.com/v3/__http:/tinyurl.com/d3d-pipeline__;!!JmoZiZGBv3RvKRSx!plX2V6Sh1Q1DDcjU0neKw87KXeMaAMufGIhGCZ5exEQu11bFNeBxI6RgKpLCG0k1CA$" target="_blank">http://tinyurl.com/d3d-pipeline</a>><br>
The Terminals Wiki <<a href="https://urldefense.com/v3/__http:/terminals-wiki.org__;!!JmoZiZGBv3RvKRSx!plX2V6Sh1Q1DDcjU0neKw87KXeMaAMufGIhGCZ5exEQu11bFNeBxI6RgKpKUVFRrCw$" target="_blank">http://terminals-wiki.org</a>><br>
The Computer Graphics Museum <<a href="https://urldefense.com/v3/__http:/ComputerGraphicsMuseum.org__;!!JmoZiZGBv3RvKRSx!plX2V6Sh1Q1DDcjU0neKw87KXeMaAMufGIhGCZ5exEQu11bFNeBxI6RgKpJkxQvkhA$" target="_blank">http://ComputerGraphicsMuseum.org</a>><br>
Legalize Adulthood! (my blog) <<a href="https://urldefense.com/v3/__http:/LegalizeAdulthood.wordpress.com__;!!JmoZiZGBv3RvKRSx!plX2V6Sh1Q1DDcjU0neKw87KXeMaAMufGIhGCZ5exEQu11bFNeBxI6RgKpKHhDdBZQ$" target="_blank">http://LegalizeAdulthood.wordpress.com</a>><br>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev__;!!JmoZiZGBv3RvKRSx!plX2V6Sh1Q1DDcjU0neKw87KXeMaAMufGIhGCZ5exEQu11bFNeBxI6RgKpKP_DwPZw$" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>