<div class="__aliyun_email_body_block"><div  style="clear:both;">Hi James and Aaron,</div><div  style="clear:both;"><br ></div><div  style="clear:both;">   Thanks for telling that. I knew the bug before. But the coroutine wouldn't resume on other thread in our production so that I forgot it. My bad. It should be critical.</div><div  style="clear:both;">   I plan changes for <span  style="caret-color:#000000;color:#000000;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;font-style:normal;font-variant-caps:normal;font-weight:normal;text-align:start;text-indent:.0px;text-transform:none;background-color:#ffffff;text-decoration:none;float:none;display:inline;">https://reviews.llvm.org/D115692 and sent https://reviews.llvm.org/D115778 based on the suggestion of Aaron. Might you take a look if it satisfied?</span></div><div  style="clear:both;"><span  style="caret-color:#000000;color:#000000;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;font-style:normal;font-variant-caps:normal;font-weight:normal;text-align:start;text-indent:.0px;text-transform:none;background-color:#ffffff;text-decoration:none;float:none;display:inline;"><br ></span></div><div  style="clear:both;"><span  style="caret-color:#000000;color:#000000;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;font-style:normal;font-variant-caps:normal;font-weight:normal;text-align:start;text-indent:.0px;text-transform:none;background-color:#ffffff;text-decoration:none;float:none;display:inline;">Thanks,</span></div><div  style="clear:both;"><span  style="caret-color:#000000;color:#000000;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;font-style:normal;font-variant-caps:normal;font-weight:normal;text-align:start;text-indent:.0px;text-transform:none;background-color:#ffffff;text-decoration:none;float:none;display:inline;">Chuanqi</span></div><div  style="clear:both;"><br ></div><blockquote  style="margin-right:0;margin-top:0;margin-bottom:0;"><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">------------------------------------------------------------------</span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">From:Aaron Ballman <aaron@aaronballman.com></span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">Send Time:2021年12月15日(星期三) 01:43</span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">To:James Y Knight <jyknight@google.com></span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">Cc:chuanqi.xcq <yedeng.yd@linux.alibaba.com>; lewissbaker <lewissbaker@gmail.com>; clang developer list <cfe-dev@lists.llvm.org></span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">Subject:Re: [cfe-dev] Is it the time to mark coroutine status as green in cxx_status page?</span></div><div  style="clear:both;"><span  style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;"><br ></span></div>On Tue, Dec 14, 2021 at 12:38 PM James Y Knight via cfe-dev<br ><cfe-dev@lists.llvm.org> wrote:<br >><br >> There hasn't been a resolution for the issue where coroutine-lowering runs optimizations passes before splitting, which breaks thread_local and __attribute__((const)) functions (affecting e.g. pthread_self() and errno). That's definitely a critical issue which must be resolved before coroutines can be reasonably called "done".<br >><br >> See thread "[llvm-dev] [RFC] Coroutine and pthread_self" thread from a year ago, e.g. https://lists.llvm.org/pipermail/llvm-dev/2020-December/147325.html for the end/summary of the conversation. (Or, starting at https://lists.llvm.org/pipermail/llvm-dev/2020-November/146766.html and https://lists.llvm.org/pipermail/llvm-dev/2020-December/147012.html)<br >><br >> Looks like there's a lot of open bugs about coroutines, https://github.com/llvm/llvm-project/issues?q=is%3Aissue+is%3Aopen+coroutine ...might be worth going through all of them...<br >> But, just cherry-picking a few about the above problem:<br >> https://github.com/llvm/llvm-project/issues/47179 (with thread_local)<br >> https://github.com/llvm/llvm-project/issues/47177 (with pthread_self)<br >> https://github.com/llvm/llvm-project/issues/49257 (with errno)<br ><br >Btw, when looking at "have we completed support for this proposal"<br >kind of questions and deciding we still have partial support, it would<br >be greatly appreciated if you could update the cxx_status (or<br >c_status) page to include rationale as to *why* we've marked something<br >as only partially supported. This is something we've only started<br >doing recently, but it helps users to know what level of support there<br >is (roughly) for a feature and it also helps maintainers understand<br >what's left to be fixed before claiming full support.<br ><br >e.g. see P0857R0 or P1073R3 on https://clang.llvm.org/cxx_status.html<br ><br >~Aaron<br ><br >><br >><br >> On Mon, Dec 13, 2021 at 9:55 PM chuanqi.xcq via cfe-dev <cfe-dev@lists.llvm.org> wrote:<br >>><br >>> Hi,<br >>><br >>>    I noticed that the status of coroutine in cxx_status page is partial previously: https://clang.llvm.org/cxx_status.html.<br >>>    This looks weird to me since coroutine is used broadly and stably in practice and I want to mark it as green. So I tried<br >>> to move coroutine out of the experimental namespace before and implement the semantics of throwing unhandled_exception()<br >>> suggested by Lewis.<br >>>    So I sent https://reviews.llvm.org/D115692 to mark coroutine as done. I want to ask if there is any blocking issue to do this?<br >>> I would love to try to fix any inconsistency.<br >>><br >>> Thanks,<br >>> Chuanqi<br >>> _______________________________________________<br >>> cfe-dev mailing list<br >>> cfe-dev@lists.llvm.org<br >>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev<br >><br >> _______________________________________________<br >> cfe-dev mailing list<br >> cfe-dev@lists.llvm.org<br >> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</blockquote><div ><br ></div></div>