<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">+1, makes sense to me.<div class=""><br class=""></div><div class="">-Chris<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On May 17, 2021, at 11:12 AM, Krzysztof Parzyszek via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">This is a revision of the previous RFC[1]. This RFC limits the scope to pre-commit reviews only.<o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><b class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Statement:<o:p class=""></o:p></span></b></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Our current code review policy states[2]:<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0in 0.5in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">“Code reviews are conducted, in order of preference, on our web-based code-review tool (see Code Reviews with Phabricator), by email on the relevant project’s commit mailing list, on the project’s development list, or on the bug tracker.”<o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">This proposal is to limit pre-commit code reviews only to Phabricator. This would apply to all projects in the LLVM monorepo. With the change in effect, the amended policy would read:<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0in 0.5in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">“Pre-commit code reviews are conducted on our web-based code-review tool (see Code Reviews with Phabricator). Post-commit reviews are conducted, in order of preference, on Phabricator, by email on the relevant project’s commit mailing list, on the project’s development list, or on the bug tracker.”<o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><b class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Current situation:<o:p class=""></o:p></span></b></div><ol start="1" type="1" style="margin-bottom: 0in; margin-top: 0in;" class=""><li class="MsoPlainText" style="margin: 0in; font-size: 10pt; font-family: Consolas;"><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">In a recent llvm-dev thread[3], Christian Kühnel pointed out that pre-commit code reviews rarely originate via an email (most are started on Phabricator), although, as others pointed out, email responses to an ongoing review are not uncommon. (That thread also contains examples of mishaps related to the email-Phabricator interactions, or email handling itself.)<o:p class=""></o:p></span></li><li class="MsoPlainText" style="margin: 0in; font-size: 10pt; font-family: Consolas;"><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">We have Phabricator patches that automatically apply email comments to the Phabricator reviews, although reportedly this functionality is not fully reliable[4,5]. This can cause review comments to be lost in the email traffic.<o:p class=""></o:p></span></li></ol><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><b class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Benefits:<o:p class=""></o:p></span></b></div><ol start="1" type="1" style="margin-bottom: 0in; margin-top: 0in;" class=""><li class="MsoPlainText" style="margin: 0in; font-size: 10pt; font-family: Consolas;"><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Single way of doing pre-commit code reviews: these code reviews are a key part of the development process, and having one way of performing them would make the process clearer and unambiguous.<o:p class=""></o:p></span></li><li class="MsoPlainText" style="margin: 0in; font-size: 10pt; font-family: Consolas;"><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Review authors and reviewers would only need to monitor one source of comments without the fear that a review comment may end up overlooked.<o:p class=""></o:p></span></li><li class="MsoPlainText" style="margin: 0in; font-size: 10pt; font-family: Consolas;"><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">This change</span><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span class="Apple-converted-space"> </span>simply codifies an existing practice.</span><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""></o:p></span></li></ol><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><b class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Concerns:</span></b><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""></o:p></span></div><ol start="1" type="1" style="margin-bottom: 0in; margin-top: 0in;" class=""><li class="MsoPlainText" style="margin: 0in; font-size: 10pt; font-family: Consolas;"><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Because of the larger variety, email clients may offer better accessibility options than web browsers.</span><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""></o:p></span></li></ol><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">[1]<span class="Apple-converted-space"> </span><a href="https://lists.llvm.org/pipermail/llvm-dev/2021-May/150344.html" style="color: rgb(5, 99, 193); text-decoration: underline;" class="">https://lists.llvm.org/pipermail/llvm-dev/2021-May/150344.html</a><o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">[2]<span class="Apple-converted-space"> </span><a href="https://llvm.org/docs/CodeReview.html#what-tools-are-used-for-code-review" style="color: rgb(5, 99, 193); text-decoration: underline;" class="">https://llvm.org/docs/CodeReview.html#what-tools-are-used-for-code-review</a><o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">[3]<span class="Apple-converted-space"> </span><a href="https://lists.llvm.org/pipermail/llvm-dev/2021-April/150129.html" style="color: rgb(5, 99, 193); text-decoration: underline;" class="">https://lists.llvm.org/pipermail/llvm-dev/2021-April/150129.html</a><o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">[4]<span class="Apple-converted-space"> </span><a href="https://lists.llvm.org/pipermail/llvm-dev/2021-April/150136.html" style="color: rgb(5, 99, 193); text-decoration: underline;" class="">https://lists.llvm.org/pipermail/llvm-dev/2021-April/150136.html</a><o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">[5]<span class="Apple-converted-space"> </span><a href="https://lists.llvm.org/pipermail/llvm-dev/2021-April/150139.html" style="color: rgb(5, 99, 193); text-decoration: underline;" class="">https://lists.llvm.org/pipermail/llvm-dev/2021-April/150139.html</a><o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><o:p class=""> </o:p></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class="">--<span class="Apple-converted-space"> </span><o:p class=""></o:p></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class="">Krzysztof Parzyszek <span class="Apple-converted-space"> </span><a href="mailto:kparzysz@quicinc.com" style="color: rgb(5, 99, 193); text-decoration: underline;" class="">kparzysz@quicinc.com</a> AI tools development<o:p class=""></o:p></div><div style="margin: 0in; font-size: 10pt; font-family: Consolas;" class=""><o:p class=""> </o:p></div></div><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">_______________________________________________</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">cfe-dev mailing list</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><a href="mailto:cfe-dev@lists.llvm.org" style="color: rgb(5, 99, 193); text-decoration: underline; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">cfe-dev@lists.llvm.org</a><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" style="color: rgb(5, 99, 193); text-decoration: underline; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a></div></blockquote></div><br class=""></div></body></html>