<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
p.MsoBodyText, li.MsoBodyText, div.MsoBodyText
{mso-style-priority:99;
mso-style-link:"Body Text Char";
margin-top:0cm;
margin-right:0cm;
margin-bottom:6.0pt;
margin-left:0cm;
line-height:106%;
font-size:10.0pt;
font-family:"Arial",sans-serif;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Arial",sans-serif;
color:windowtext;}
span.BodyTextChar
{mso-style-name:"Body Text Char";
mso-style-priority:99;
mso-style-link:"Body Text";
font-family:"Arial",sans-serif;
mso-fareast-language:EN-GB;}
span.LiteralChar
{mso-style-name:"Literal Char";
mso-style-link:Literal;
font-family:"Courier New";
mso-fareast-language:EN-GB;}
p.Literal, li.Literal, div.Literal
{mso-style-name:Literal;
mso-style-link:"Literal Char";
margin-top:0cm;
margin-right:0cm;
margin-bottom:6.0pt;
margin-left:0cm;
line-height:106%;
font-size:10.0pt;
font-family:"Courier New";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoBodyText">An availability attribute parsing test is failing on XCore. Is this the right fix?<o:p></o:p></p>
<p class="MsoBodyText">Test file clang/test/Parser/attr-availability.c, function f8, tests that<o:p></o:p></p>
<p class="MsoBodyText">__attribute__((availability(macosx,message="a" L"b")))<o:p></o:p></p>
<p class="MsoBodyText">gives error "expected string literal for optional message in 'availability' attribute", because "a" L"b" should be concatenated into a wide string.<o:p></o:p></p>
<p class="MsoBodyText">The check is made in clang/lib/Parse/ParseDecl.cpp, Parser::ParseAvailabilityAttribute, comment "Also reject wide string literals". But the code checks (1) that the first token in the string concatenation is a (non-wide) string literal,
and then (2) that the resulting string consists of 1-byte characters.<o:p></o:p></p>
<p class="MsoBodyText">On XCore, wchar_t is unsigned char, so "a" L"b" passes both checks, and the expected diagnostic is not issued. But plain L"b" would be rejected. This is inconsistent.<o:p></o:p></p>
<p class="MsoBodyText">Can I fix:<o:p></o:p></p>
<p class="Literal">if (MessageStringLiteral->getCharByteWidth() != 1)<o:p></o:p></p>
<p class="MsoBodyText">to:<o:p></o:p></p>
<p class="Literal">if (!MessageStringLiteral->isAscii())<o:p></o:p></p>
<p class="MsoBodyText">or is there a reason for the width test specifically? <o:p>
</o:p></p>
<p class="MsoBodyText">Thanks,<o:p></o:p></p>
<p class="MsoBodyText">Nigel<o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial",sans-serif"><o:p> </o:p></span></p>
</div>
</body>
</html>