<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks for the heads up.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I guess this is related to the change that Matt has committed around a year ago: <a href="https://reviews.llvm.org/D69878" id="LPlnk314231">
https://reviews.llvm.org/D69878</a><br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I think you should be able to achieve the same behaviour by using -fdenormal-fp-math-f32==ieee in cc1 mode. Many flags in OpenCL duplicate the existing compiler flags and therefore the idea is to keep them in the regular driver mode but with -cc1 we can just
reuse the standard C/C++ interfaces.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
However, I feel the documentation should be improved. Otherwise, I am not sure it is obvious what this flag corresponds to.<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Cheers,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Anastasia<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> David Airlie <airlied@redhat.com><br>
<b>Sent:</b> 11 November 2020 04:03<br>
<b>To:</b> cfe-dev (cfe-dev@lists.llvm.org) <cfe-dev@lists.llvm.org>; ben.ashbaugh@intel.com <ben.ashbaugh@intel.com>; Anastasia Stulova <Anastasia.Stulova@arm.com><br>
<b>Subject:</b> Re: -cl-denorms-are-zero no longer accepted in cc1 mode</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">This may just be an artifact of how clover doesn't use the clang<br>
driver at all, which might mean everyone else is fine and clover just<br>
does it wrong.<br>
<br>
But maybe someone else has done it wrong as well, so might appreciate<br>
this headsup.<br>
<br>
Dave.<br>
<br>
On Wed, Nov 11, 2020 at 10:36 AM David Airlie <airlied@redhat.com> wrote:<br>
><br>
> I've been working on the mesa clover (OpenCL) frontend code.<br>
><br>
> it calls<br>
> clang::CompilerInvocation::CreateFromArgs<br>
> to create a clang compiler, but it passes the arguments it receives<br>
> from the OpenCL clBuildProgram API (-cl-denorms-are-zero) being one.<br>
> It currently doesn't strip any of those args out.<br>
><br>
> Now I can prepare the args and strip that one out if necessary, though<br>
> I'm not quite sure what I need to pass instead (since I want to<br>
> generate llvm bytecode to pass to the llvm->spirv translator).<br>
><br>
> But I wanted to give a heads up to other OpenCL implementers that<br>
> might have the same pattern (passing the options straight to clang),<br>
> but also check if this is what we expect.<br>
><br>
> Thanks,<br>
> Dave.<br>
<br>
</div>
</span></font></div>
</body>
</html>