<div dir="ltr"><div>Thanks everyone!</div><div><br></div><div>I would like to keep the bots in the staging till Friday. And if everything is good, then apply the changes to the production and let you move all the green bots back there.</div><br><div>Thanks</div><div><br></div><div>Galina<br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 13, 2020 at 10:43 PM Vitaly Buka <<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">They do on staging. <div><a href="http://lab.llvm.org:8014/#/builders/sanitizer-windows" target="_blank">http://lab.llvm.org:8014/#/builders/sanitizer-windows</a><br><a href="http://lab.llvm.org:8014/#/builders/clang-x64-windows-msvc" target="_blank">http://lab.llvm.org:8014/#/builders/clang-x64-windows-msvc</a></div><div><br></div><div>Galina, when do you plan to push this to the primary server?</div><div>If it's a few days, I'd rather keep bots on staging to have colors.</div><div><br><div><div><br></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 13 Oct 2020 at 11:11, Reid Kleckner <<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">FWIW, I don't see any issues with my two bots that use buildbot annotated commands:<div><a href="http://lab.llvm.org:8011/#/builders/sanitizer-windows" target="_blank">http://lab.llvm.org:8011/#/builders/sanitizer-windows</a><br></div><div><a href="http://lab.llvm.org:8011/#/builders/clang-x64-windows-msvc" target="_blank">http://lab.llvm.org:8011/#/builders/clang-x64-windows-msvc</a><br></div><div>The individual steps don't highlight as green or red, but that's OK for now.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 12, 2020 at 7:19 PM Galina Kistanova <<a href="mailto:gkistanova@gmail.com" target="_blank">gkistanova@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div>We have a better version of AnnotatedCommand on the staging. It should be a functional equivalent of the old one.</div><div>We need to stress test it well before moving to the production build bot.</div><div><br></div><div>For that we need all sanitizer + other bots which use the AnnotatedCommand directly or indirectly moved temporarily to the staging.</div><div><br></div><div>Please let me know when that could be arranged.</div><div><br></div><div>Thanks</div><div><br></div><div>Galina<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 12, 2020 at 11:39 AM Reid Kleckner <<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Wed, Oct 7, 2020 at 4:32 PM Galina Kistanova via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>They are online now - <a href="http://lab.llvm.org:8011/#/waterfall?tags=sanitizer" target="_blank">http://lab.llvm.org:8011/#/waterfall?tags=sanitizer</a></div><div><br></div><div>AnnotatedCommand has severe design conflict with the new buildbot.</div><div>We have changed it to be safe and still do something useful, but it will need more love and care.</div><div><br></div><div>Please let me know if you have some spare time to work on porting AnnotatedCommand.</div></div></blockquote><div><br></div><div>That's unfortunate, it would've been good to know that earlier. I and another team member have spent a fair amount of time porting things to use more AnnotatedCommand steps, because it gives us the flexibility to test steps locally and make changes to the steps without restarting the buildbot master. IMO that is the Right Way to define steps: a script that you can run locally on a machine that satisfies the OS and dep requirements of the script.</div><div><br></div><div>I am restarting the two bots that I am responsible for, and may need some help debugging further issues soon. I'll let you know. </div></div></div>
</blockquote></div>
</div>
</blockquote></div>
</blockquote></div>
</blockquote></div>