<div dir="ltr">Hello Min-Yih,<div>Yes, I added <b>clang-c</b> group as reviewers<br><br>Regards,<br>Nadaf.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 22, 2020 at 3:39 PM Min-Yih Hsu <<a href="mailto:minyihh@uci.edu">minyihh@uci.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;">I will recommend to at least assign the code owners of that section as reviewers. Empty reviewer list will make that ticket never being closed.<div><br></div><div>-Min<br><div><br><blockquote type="cite"><div>On Jul 22, 2020, at 12:18 PM, Gousemoodhin Nadaf via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:</div><br><div><div dir="ltr">Hello Team,<br>Please review changes:
<a href="https://reviews.llvm.org/D83929" target="_blank">https://reviews.llvm.org/D83929</a><br><br><b>Problem:</b> Compiler crash, compiler does not check explicit declaration context, whether it is inside class context or not, this check is missing.<br><br><b>Solution</b>: I have added a check when the compiler encounters the 'explicit' keyword, the first compiler has to check its declaration context. If the declaration of 'explicit' the keyword is in the class context, it is correct, else the compiler has to throw warning message (not crash).<br><br>Regards,<br>Nadaf.</div>
_______________________________________________<br>cfe-dev mailing list<br><a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br></div></blockquote></div><br></div></div></blockquote></div>