<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">I will recommend to at least assign the code owners of that section as reviewers. Empty reviewer list will make that ticket never being closed.<div class=""><br class=""></div><div class="">-Min<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 22, 2020, at 12:18 PM, Gousemoodhin Nadaf via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hello Team,<br class="">Please review changes:
<a href="https://reviews.llvm.org/D83929" class="">https://reviews.llvm.org/D83929</a><br class=""><br class=""><b class="">Problem:</b> Compiler crash, compiler does not check explicit declaration context, whether it is inside class context or not, this check is missing.<br class=""><br class=""><b class="">Solution</b>: I have added a check when the compiler encounters the 'explicit' keyword, the first compiler has to check its declaration context. If the declaration of 'explicit' the keyword is in the class context, it is correct, else the compiler has to throw warning message (not crash).<br class=""><br class="">Regards,<br class="">Nadaf.</div>
_______________________________________________<br class="">cfe-dev mailing list<br class=""><a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a><br class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev<br class=""></div></blockquote></div><br class=""></div></body></html>