<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<div class="moz-cite-prefix">On 02/07/2020 12:23, Manuel Klimek
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAOsfVvm+FJ4ezrx0Zv7dDP2XxEMy6F7bTr1XCbGMzff+1JHFog@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Jul 2, 2020 at 12:50
PM Aaron Ballman via cfe-dev <<a
href="mailto:cfe-dev@lists.llvm.org"
moz-do-not-send="true">cfe-dev@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">> I don't want to be
left with the blame of having my design half-implemented
though :). There are bugs that I can not fix, partly because
this is not concluded.<br>
><br>
> If I can't move forward, then reversal is the only way
(to give others the space to validate their designs) and I'd
like to do that soon, so that this thread is not an open
item for me (or anyone else) to deal with.<br>
<br>
While I was previously in favor of switching the default
because I<br>
thought it would lead to easier AST matching, I've been
convinced by<br>
the concerns raised on the thread and I think that we should
revert<br>
the default to AsIs. Despite that, Stephen: thank you for
all your<br>
efforts on this and I'm sorry that the experiment hasn't
worked out<br>
the way we had anticipated.<br>
</blockquote>
<div><br>
</div>
<div>+1 - I think it was mainly too early to flip the default
- we need to iterate on the mode (or an alternative, like
what Richard and others suggested) before we try to flip
defaults again.</div>
</div>
</div>
</blockquote>
<p>The change is here ready for review:</p>
<p><a class="moz-txt-link-freetext" href="https://reviews.llvm.org/D83076">https://reviews.llvm.org/D83076</a></p>
<p>Sorry about the churn of introducing the change of default. At
least traverse() matchers introduced then will continue to work
without requiring extra churn.<br>
</p>
<p>Thanks,</p>
<p>Stephen.</p>
<p><br>
</p>
<p><br>
</p>
<p><br>
</p>
</body>
</html>