<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<div class="moz-cite-prefix">On 27/05/2020 11:42, Stephen Kelly
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CACHsx4L=Qrwt47nGBAR9FcDH_a4gC24fwycJnqRZjFM4HTV+Qg@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
I have a proof of concept patch which adds a virtual method to
ClangTidyCheck which returns an overriding
optional<TraversalKind> to use for the check. If you
reimplement that method in your downstream checks to return AsIs
then you don't have to change individual matchers yet.
<div dir="auto">
<div dir="auto"><br>
</div>
<div dir="auto">What do you think?</div>
<div dir="auto"><br>
</div>
<div dir="auto">I have the patch on a computer I will have
access to in about 2 hours. <br>
</div>
</div>
</blockquote>
<p><br>
</p>
<p>I have uploaded that patch here: <a class="moz-txt-link-freetext" href="https://reviews.llvm.org/D80623">https://reviews.llvm.org/D80623</a><br>
</p>
<p>It is WIP as it does not include a test. Let me know if you think
that is an interesting direction and we can finish the patch.<br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:CACHsx4L=Qrwt47nGBAR9FcDH_a4gC24fwycJnqRZjFM4HTV+Qg@mail.gmail.com">
<div dir="auto">
<div dir="auto">Sorry for the disruption. At least the issue is
getting visibility here and feedback already indicates that
the release notes could be more informative. <br>
</div>
</div>
</blockquote>
<p><br>
</p>
<p>I have added a detailed porting guide to the release notes.
Hopefully by the time anyone reads this email they will be updated
here:</p>
<p> <a class="moz-txt-link-freetext" href="https://clang.llvm.org/docs/ReleaseNotes.html#ast-matchers">https://clang.llvm.org/docs/ReleaseNotes.html#ast-matchers</a><br>
</p>
<p>I will be away now for a few hours. I'll look more into the bug
discovered via the transform library when I return.</p>
<p>Thanks,</p>
<p>Stephen.<br>
</p>
<p><br>
</p>
<div dir="auto">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
</blockquote>
</div>
</div>
</body>
</html>