<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="HU" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi!<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Question:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Why is the dependency on ClangTooling ill-advised inside ClangSA (also meaning the Clang binary) itself ?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Context:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Currently I am working on an alternative way to import external TU AST-s during analysis (
<a href="https://reviews.llvm.org/D75665">https://reviews.llvm.org/D75665</a> ).<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">In order to produce AST-s, I use a compilation database to extract the necessary flags, and finally use ClangTool::buildAST.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I am aware that I have other options for this as well (like manually coding the compdb handling for my specific case for the<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">first step, and maybe even dumping ASTs as pch-s into an in-memory buffer), but still consuming JSONCompilationDatabase<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">is just too convenient. I would not want to introduce another format when compilation database is just right for this purpose.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Elaboration:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">While I understand that introducing dependencies has its downsides, but not being able to reuse code from Tooling is also not ideal.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I would very much like to be enlightened by someone more familiar with architectural decision already made why this is the case,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">and optionally how I could proceed with my efforts so that I can come up with the most fitting solution i.e. not a hack.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Endre F</span>ülöp<span lang="EN-US"><o:p></o:p></span></p>
</div>
</body>
</html>