<div dir="ltr"><div>Hi all,<br><br>On a Phabricator review (<a href="https://reviews.llvm.org/D78704">https://reviews.llvm.org/D78704</a>) the `<span style="font-family:monospace">GTEST_SKIP</span>` was<br>mentioned as a way to express requirements for a test. In that patch, I wanted<br>to skip the test if clang was not built with Z3.<br><br>I think this `<span style="font-family:monospace">GTEST_SKIP</span>` macro express the intention much better than the<br>following code that I saw throughout the codebase:<br><br>```<br><span style="font-family:monospace">#define CHECK_UNSUPPORTED() \<br>  do { \<br>    if (isUnsupportedOSOrEnvironment()) \<br>      return; \<br>  } while (0);</span><br>```<br><br><br>There are several places where we might benefit from the `GTEST_SKIP` macro:<br>- <a href="https://github.com/llvm/llvm-project/blob/master/llvm/unittests/ExecutionEngine/MCJIT/MCJITTestAPICommon.h#L29-L33">llvm/unittests/ExecutionEngine/MCJIT/MCJITTestAPICommon.h:29</a><br>- <a href="https://github.com/llvm/llvm-project/blob/master/llvm/unittests/Support/ThreadPool.cpp#L81-L85">llvm/unittests/Support/ThreadPool.cpp:81</a><br>- <a href="https://github.com/llvm/llvm-project/blob/master/llvm/unittests/Support/MemoryTest.cpp#L89-L94">llvm/unittests/Support/MemoryTest.cpp:89</a><br><br>It is possible that the upgrade would introduce other benefits as well - which<br>I'm not aware of.<br><br></div>Should we upgrade googletest to version 1.10.0?<br><div><br>/CC Chandler<br><br>Balazs.</div></div>