<div dir="ltr">Hmm seems the code you posted is out of date, 8a3446746098ba29348bb8f85357dd0b466a6d6e (1.16.20) fixed this issue.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 3, 2020 at 10:55 PM Johnson, Troy <<a href="mailto:troy.johnson@hpe.com">troy.johnson@hpe.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
The accessor can return null intermittently? Why?</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
-Troy<br>
</div>
<div id="gmail-m_7286065102780794776appendonsend"></div>
<hr style="display:inline-block;width:98%">
<div id="gmail-m_7286065102780794776divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Saar Raz <saar@raz.email><br>
<b>Sent:</b> Friday, April 3, 2020 2:48 PM<br>
<b>To:</b> Johnson, Troy <<a href="mailto:troy.johnson@hpe.com" target="_blank">troy.johnson@hpe.com</a>><br>
<b>Cc:</b> Richard Smith <<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>>; Clang Dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>><br>
<b>Subject:</b> Re: [cfe-dev] intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp</font>
<div> </div>
</div>
<div>
<div dir="auto">Hey,
<div dir="auto">Didn't reproduce yet but I know how to fix the issue. That accessor can return null and there should be a null check there. </div>
<div dir="auto">I'll push a fix as soon as I can.</div>
<div dir="auto">Thanks! </div>
</div>
<br>
<div>
<div dir="ltr">On Fri, Apr 3, 2020, 10:23 PM Johnson, Troy <<a href="mailto:troy.johnson@hpe.com" target="_blank">troy.johnson@hpe.com</a>> wrote:<br>
</div>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
Has anyone tried to reproduce this yet?<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
Thanks,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
Troy<br>
</div>
<div id="gmail-m_7286065102780794776x_m_-202014215694383247appendonsend"></div>
<hr style="display:inline-block;width:98%">
<div id="gmail-m_7286065102780794776x_m_-202014215694383247divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Richard Smith <<a href="mailto:richard@metafoo.co.uk" rel="noreferrer" target="_blank">richard@metafoo.co.uk</a>><br>
<b>Sent:</b> Tuesday, March 24, 2020 5:46 PM<br>
<b>To:</b> Johnson, Troy <<a href="mailto:troy.johnson@hpe.com" rel="noreferrer" target="_blank">troy.johnson@hpe.com</a>>; Saar Raz <saar@raz.email><br>
<b>Cc:</b> <a href="mailto:cfe-dev@lists.llvm.org" rel="noreferrer" target="_blank">
cfe-dev@lists.llvm.org</a> <<a href="mailto:cfe-dev@lists.llvm.org" rel="noreferrer" target="_blank">cfe-dev@lists.llvm.org</a>><br>
<b>Subject:</b> Re: [cfe-dev] intermittent lit failure: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp</font>
<div> </div>
</div>
<div>
<div dir="ltr">+Saar for all things concepts.<br>
</div>
<br>
<div>
<div dir="ltr">On Tue, 24 Mar 2020 at 13:23, Johnson, Troy via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" rel="noreferrer" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<br>
</div>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
The test fails about 1 in 10 or 20 runs when I execute it via llvm-lit repeatedly in a shell loop. It encounters a null pointer dereference in this code in clang/lib/AST/StmtProfile.cpp:<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
<span>void StmtProfiler::VisitConceptSpecializationExpr(<br>
</span>
<div> const ConceptSpecializationExpr *S) {<br>
</div>
<div> VisitExpr(S);<br>
</div>
<div> VisitDecl(S->getFoundDecl());<br>
</div>
<div> VisitTemplateArguments(S->getTemplateArgsAsWritten()->getTemplateArgs(),<br>
</div>
<div> S->getTemplateArgsAsWritten()->NumTemplateArgs);<br>
</div>
<span>}</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
The S->getTemplateArgsAsWritten() call returns null.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
I have not been able to determine why the behavior is intermittent. Is there someone more familiar with this code who has an idea?<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0);background-color:rgb(255,255,255)">
-Troy<br>
</div>
</div>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" rel="noreferrer" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote></div>