<div dir="ltr"><div>IMO, it would be less confusing to just change the default to false across the board. </div><div><br></div><div>If anything should still use -fcommon by default, I'd want that to be based on vendor/OS, not CPU.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 24, 2020 at 11:38 AM Sjoerd Meijer via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
> <span>Is there any reason to limit this to just the ARM targets?</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span><br>
</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span>No good reason other than that I don't know how beneficial this is for other targets.</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span>But I definitely don't mind giving other targets the same treatment though while I am at it.</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span><br>
</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span>Cheers,</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span>Sjoerd.</span></div>
<div id="m_2997084966552717811m_6283520958751486821gmail-m_3177972649899444702appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<hr style="display:inline-block;width:98%">
<div id="m_2997084966552717811m_6283520958751486821gmail-m_3177972649899444702divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Tom Stellard <<a href="mailto:tstellar@redhat.com" target="_blank">tstellar@redhat.com</a>><br>
<b>Sent:</b> 24 February 2020 16:31<br>
<b>To:</b> Sjoerd Meijer <<a href="mailto:Sjoerd.Meijer@arm.com" target="_blank">Sjoerd.Meijer@arm.com</a>>; <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a> Developers <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>><br>
<b>Subject:</b> Re: [cfe-dev] [ARM][AArch64] Default to -fno-common</font>
<div> </div>
</div>
<div><font size="2"><span style="font-size:11pt">
<div>On 02/24/2020 08:28 AM, Sjoerd Meijer via cfe-dev wrote:<br>
> Hello,<br>
> <br>
> Subject says most of it: I would like to propose that the Arm targets default to -fno-common for performance and code-size reasons. In addition, GCC has also flipped the switch recently, see [1], so we would get the same behaviour as GCC which would also
be nice. I've learned that the switch for GCC was relatively straightforward (for users), and there is some GNU documentation with Q&As to help toolchain users to transition if they find problems. I have put a draft patch up for review here:
<a href="https://reviews.llvm.org/D75056" target="_blank">https://reviews.llvm.org/D75056</a>. This definitely needs some doc changes (and I need to look at the tests), but first I would like to see how we feel about flipping the switch: any ideas, comments, objections?<br>
> <br>
<br>
Is there any reason to limit this to just the ARM targets?<br>
<br>
-Tom<br>
<br>
> Cheers,<br>
> Sjoerd.<br>
> <br>
> <br>
> [1] The GCC commit:<br>
> <br>
> commit 6271dd984d7f920d4fb17ad37af6a1f8e6b796dc<br>
> Author: Wilco Dijkstra <<a href="mailto:wdijkstr@arm.com" target="_blank">wdijkstr@arm.com</a>><br>
> Date: Wed Nov 20 16:29:23 2019 +0000<br>
> <br>
> PR85678: Change default to -fno-common<br>
> GCC currently defaults to -fcommon. As discussed in the PR, this is an ancient<br>
> C feature which is not conforming with the latest C standards. On many targets<br>
> this means global variable accesses have a codesize and performance penalty.<br>
> This applies to C code only, C++ code is not affected by -fcommon. It is about<br>
> time to change the default.<br>
> <br>
> <br>
> _______________________________________________<br>
> cfe-dev mailing list<br>
> <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
> <br>
<br>
</div>
</span></font></div>
</div>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div></div>