<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 1/31/20 9:30 AM, David Blaikie via
cfe-dev wrote:<br>
</div>
<blockquote type="cite" cite="mid:CAENS6EvnnrtnK-C9KK2CDH9Zxec5B7vDTHpffYVjCxNo6TYyJA@mail.gmail.com">
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Jan 31, 2020 at 6:09
AM Robinson, Paul via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex"><br>
<br>
> -----Original Message-----<br>
> From: cfe-dev <<a href="mailto:cfe-dev-bounces@lists.llvm.org" target="_blank" moz-do-not-send="true">cfe-dev-bounces@lists.llvm.org</a>>
On Behalf Of John Marshall<br>
> via cfe-dev<br>
> Sent: Friday, January 31, 2020 7:04 AM<br>
> To: Jonas Devlieghere via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>><br>
> Subject: Re: [cfe-dev] [llvm-dev] Phabricator ->
GitHub PRs?<br>
> <br>
> On 8 Jan 2020, Jonas Devlieghere wrote:<br>
> > I believe that technically sending patches to the
mailing list is<br>
> > still a valid way to get your code reviewed. Not
everyone monitors the<br>
> > mailing list actively though so that might turn
out to be more<br>
> > frustrating than Phabricator.<br>
> <br>
> I can confirm that this is indeed frustrating.<br>
> <br>
> I am only a user of Clang (and a former very minor
contributor to GCC) but<br>
> I was recently sufficiently piqued by a small Clang
diagnostic infelicity<br>
> that I looked into fixing it, and came up with what
appears to this<br>
> neophyte to be a trivial 2-line fix. As a first-time
contributor to Clang,<br>
> I read the instructions for contributing at<br>
> <<a href="http://clang.llvm.org/get_involved.html" rel="noreferrer" target="_blank" moz-do-not-send="true">http://clang.llvm.org/get_involved.html</a>>:<br>
> <br>
> "Clang is a subproject of the LLVM Project, but
has its own mailing<br>
> lists because the communities have people with
different interests. The<br>
> two clang lists are:<br>
> • cfe-commits - This list is for patch
submission/discussion.<br>
> [snip]"<br>
> <br>
> And at <<a href="https://llvm.org/docs/GettingStarted.html#sending-patches" rel="noreferrer" target="_blank" moz-do-not-send="true">https://llvm.org/docs/GettingStarted.html#sending-patches</a>>
(via<br>
> <<a href="http://clang.llvm.org/hacking.html#patches" rel="noreferrer" target="_blank" moz-do-not-send="true">http://clang.llvm.org/hacking.html#patches</a>>:
"To contribute changes to<br>
> Clang see LLVM's Getting Started page"):<br>
> <br>
> "We don’t currently accept github pull requests,
so you’ll need to<br>
> send patches either via emailing to llvm-commits, or,
preferably, via<br>
> Phabricator."<br>
> <br>
> Having a trivial one-off patch to propose, and
presented with a choice of<br>
> creating a Phabricator account at llvm and learning how
to use it or<br>
> simply sending the patch via email -- obviously I chose
the latter [1].<br>
> It's only been 10 days but there have been no replies
and around 2000<br>
> other emails on the list since then. Of those ~2000, I
noticed three that<br>
> were not automatically generated -- one of which was a
reply to another<br>
> newbie, so well done Jonas Toth! [2]<br>
> <br>
> Apart from that one instance of a reply, it would
appear that 99+% of the<br>
> messages on cfe-commits these days are automatically
generated and hence<br>
> that approximately zero people are actively monitoring
the mailing list.<br>
> So it would probably be good to update the contributing
instructions to<br>
> reflect reality.<br>
> <br>
> John<br>
<br>
I expect 99+% of the messages on cfe-commits are
automatically generated,<br>
but that doesn't mean nobody reads the list. I'm not the
only one who<br>
finds the Phabricator UI to be appallingly bad or even
impenetrable, for<br>
anything more sophisticated than posting comments. (I also
have a recipe<br>
for posting new patches, learned through trial and many
errors.)<br>
I certainly don't use the web UI for figuring out which
patches to read<br>
and/or comment on; I use the mailing list for that.
Regretfully I don't<br>
do much with the Clang sub-project.<br>
<br>
The protocol for proposed patches is effectively the same
for emailed<br>
patches as for Phab patches: directly CC people who would
appear to be<br>
appropriate reviewers, and reply with a "ping" every week or
so if there<br>
are no responses. This will bump the patch up in the
mailing list queue<br>
on the list, and (one hopes) the direct CC will be noticed
by people who<br>
don't ordinarily read the list.<br>
</blockquote>
<div><br>
+1 to all that from me - I don't use Phab to manage my
review queue - I use the mailing list.</div>
</div>
</div>
</blockquote>
<p><br>
</p>
<p>Same for me. I use the mailing list, and skim everything.
However, I don't have time to reply to everything, so unless it's
something which I really must follow very closely (or an email
with no one cc'd, and obviously will need certain people cc'd),
I'll wait for "ping" emails to see if it's something I can
usefully help move along.<br>
</p>
<p> -Hal<br>
</p>
<p><br>
</p>
<blockquote type="cite" cite="mid:CAENS6EvnnrtnK-C9KK2CDH9Zxec5B7vDTHpffYVjCxNo6TYyJA@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div> I do skim through all the commits lists on a weekly
(well, I think it's been a couple of weeks now) basis &
try to CC relevant people on reviews if they're not
something I have the time/knowledge to look at, etc.<br>
<br>
- Dave </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<br>
HTH,<br>
--paulr<br>
<br>
> <br>
> <br>
> [1] <a href="http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-" rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-</a><br>
> 20200120/302838.html<br>
> [2] <a href="http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-" rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-</a><br>
> 20200127/304742.html<br>
> _______________________________________________<br>
> cfe-dev mailing list<br>
> <a href="mailto:cfe-dev@lists.llvm.org" target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
cfe-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
</body>
</html>