<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 7, 2020, at 19:52, Hubert Tong <<a href="mailto:hubert.reinterpretcast@gmail.com" class="">hubert.reinterpretcast@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 7, 2020 at 10:36 PM Jonas Devlieghere via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Jan 7, 2020 at 7:32 PM Daniel Sanders<br class="">
<<a href="mailto:daniel_l_sanders@apple.com" target="_blank" class="">daniel_l_sanders@apple.com</a>> wrote:<br class="">
><br class="">
> I'm not sure a decision was already made as such. I think it's more that there was a flurry of conversation last time with lots of conflicting opinions, and then the conversation just fizzled out.<br class="">
><br class="">
> FWIW, I like Phabricator but I'm willing to try GitHub. Overall I think we should take the same approach that eventually led to Phabricator being widely adopted: We should allow GitHub PR's and see if the community generally settles on one or the other.<br class=""></blockquote><div class="">This means that people proposing patches control the apparent behaviour. How is someone that is primarily a reviewer meant to voice their opinion under such a system?<br class=""></div></div></div>
</div></blockquote><br class=""></div><div>When Phabricator was being introduced there were a few groups of reviewers who would ask for Phabricator patches to be re-sent by email and a few who would ask for emails to re-posted on Phabricator. To get my code reviewed I'd go along with whatever the reviewers in the area I wanted to change preferred. Over time, more reviewers asked for Phabricator and fewer asked for email.</div></body></html>