<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi,</p>
<p>thats a good approach to learning clang-tidy!<br>
I think it is ok to write some tests and then post it for
code-review. Just add "[clang-tidy] ..." in the title and then the
right reviewers will pick it up :)</p>
<p>Don't be afraid or hesitate for code review. From my experience
thats the best way to get introduced into the code base.</p>
<p>Best Regards<br>
Jonas<br>
</p>
<div class="moz-cite-prefix">Am 20.10.19 um 11:43 schrieb Kim
Viggedal via cfe-dev:<br>
</div>
<blockquote type="cite"
cite="mid:CAEvnEbfJhGmxBx1DeQO1iJVutoiZ68C+E20e48Bsm1Z2a10JoA@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">Hi, I'm writing for the first time to this mailing
list and hoping to be able to make some contributions to clang
tidy in the future. I'm a bit excited<br>
!<br>
I wanted to learn how to write clang checks for clang tidy and I
figured a good start would be to see if there are any simple
checks missing from cpp core guidelines. I couldn't find an
implementation for this check: <a
href="https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Ri-global"
moz-do-not-send="true">https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Ri-global</a> <br
clear="all">
<div>-and so I assumed that it was needed and it seemed like a
good check for a beginning clang tidy contributor.<br>
<br>
I have started work on the implementation but I haven't tested
it much and I haven't written the unit test so I'm not ready
for a review, however I figured it would still be good to
check in with the mailing list to confirm that the check
actually isn't implemented somewhere else or currently being
worked on by someone else.<br>
<br>
Also I thought that by bringing this up now I might find an
appropriate reviewer for my patch once it is ready for review,
provided it is a reasonable change and something to continue
working on.<br>
<br>
Am I on a good track or should I use a different approach for
starting to contribute clang tidy checks?<br>
<br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">/Kim Viggedal</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
cfe-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
</body>
</html>