<div dir="ltr">Thanks for the heads-up!<div><br></div><div>akhuang gave the combined patch a try on Chromium. The improved warnings found two bugs and had no false positives :)</div><div><br></div><div>(<a href="https://bugs.chromium.org/p/chromium/issues/detail?id=992863#c1">https://bugs.chromium.org/p/chromium/issues/detail?id=992863#c1</a> has the details.)</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 9, 2019 at 10:16 PM Richard Trieu via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I have been working on several patches to improve Clang warnings.  The changes touch warnings that are in the default warning set or in common build configurations.  I am posting these patches so interested people can test the warning behavior before they committed.  In my testing, these warnings have caught many interesting and hard to find bugs already.</div><div><br></div><div>I've combined all the patches into one for easy testing: </div><div></div><div><a href="https://reviews.llvm.org/D66048" target="_blank">https://reviews.llvm.org/D66048</a><br><br>Individual patches, spread out:<br><a href="https://reviews.llvm.org/D66043" target="_blank">https://reviews.llvm.org/D66043</a> - New precedence warning for mixing bitwise and/or with conditional operator<br><a href="https://reviews.llvm.org/D66044" target="_blank">https://reviews.llvm.org/D66044</a> - -Wtautological-overlap-compare to work on negative numbers<br><a href="https://reviews.llvm.org/D66045" target="_blank">https://reviews.llvm.org/D66045</a> - Better detection of same value operands for tautological warnings<br><a href="https://reviews.llvm.org/D66046" target="_blank">https://reviews.llvm.org/D66046</a> - New warning -Wtautological-bitwise-compare to check for non-zero value bitwise-or in bool context<br><br>These are improvements to -Wparentheses, -Wtautological-compare, and -Wtautological-overlap-compare with new warning -Wtautological-bitwise-compare.  <br></div></div>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div>