<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class=""><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div class="">Additionally to fixing the issue described above, Harlan (CCed) and I would like to also perform the following minor cleanups and improvements:</div><div class=""><br class=""></div><div class="">- Start using error_code/ErrorOr for FileManager for improved API.</div></div></div></div></div></div></div></blockquote><div><br class=""></div>As a first step of this refactor, I’ve posted a patch that changes FileManager::getFile and FileManager::getDirectory to use llvm::ErrorOr.</div><div><br class=""></div><div><a href="https://reviews.llvm.org/D65534" class="">https://reviews.llvm.org/D65534</a></div><div><br class=""></div><div>It’s a big patch, but the bulk of the changes are updating clients throughout clang, lldb, and clang-tools-extra.</div><br class=""></div><div class="">— Harlan</div></body></html>