<div dir="ltr">We already have a DEF_TRAVERSE_DECL macro that contains the boilerplate common to all Decl traversals, moving it there seems to give the desired behavior.<div>I've sent <a href="https://reviews.llvm.org/D64907">https://reviews.llvm.org/D64907</a> for review, let's see whether Richard thinks it's a good idea.<br><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 18, 2019 at 11:01 AM Kim Gräsman <<a href="mailto:kim.grasman@gmail.com">kim.grasman@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I looked quickly at RecursiveASTVisitor.h, and it looks like the<br>
challenge is that attributes can be attached to other decls as well.<br>
<br>
Attrs are traversed generically for all Decl after any dynamic-type traversal:<br>
<a href="https://github.com/llvm/llvm-project/blob/master/clang/include/clang/AST/RecursiveASTVisitor.h#L707" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/blob/master/clang/include/clang/AST/RecursiveASTVisitor.h#L707</a><br>
<br>
So I think in order to change this, attribute traversal would need to<br>
be custom-implemented for every kind of Decl.<br>
<br>
- Kim<br>
<br>
On Thu, Jul 18, 2019 at 10:54 AM Ilya Biryukov via cfe-dev<br>
<<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<br>
><br>
> I would agree the traversal order is wrong, attributes are logically attached to a function, i.e. they are "child nodes".<br>
> Therefore, they should be traversed alongside others child nodes (function body, type, etc).<br>
><br>
><br>
> On Thu, Jul 18, 2019 at 10:35 AM Max Sagebaum <<a href="mailto:max.sagebaum@scicomp.uni-kl.de" target="_blank">max.sagebaum@scicomp.uni-kl.de</a>> wrote:<br>
>><br>
>> Hello Ilya,<br>
>><br>
>> thank you for the fast reply. I do not know why I missed that.<br>
>><br>
>> Nevertheless, is the traversal order correct?<br>
>><br>
>> Cheers<br>
>><br>
>> Max<br>
>><br>
>> On Thu, 2019-07-18 at 09:40 +0200, Ilya Biryukov wrote:<br>
>><br>
>> Hi Max,<br>
>><br>
>> You can get the attributes with Decl::attrs() method (also available for FunctionDecl).<br>
>><br>
>> On Thu, Jul 18, 2019 at 9:28 AM Max Sagebaum via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<br>
>><br>
>> Hello @ all,<br>
>><br>
>> I want to annotate some function and generate some additional properties for the annotated functions in an xml document. My problem is, that the AST traversal seems to traverse the attributes of the function after the traversal of the function has been finished. I could not find any valuable resources on this topic by searching via google. So I am addressing my question here.<br>
>><br>
>> (Since I do not know if file attachments are allowed I provide the files as comments.)<br>
>><br>
>> My test files is: (attributeTest.cpp)<br>
>><br>
>> void func1()<br>
>> __attribute((annotate(R"(Test)"))) {<br>
>> int a = 1 + 1;<br>
>> }<br>
>><br>
>><br>
>> clang-check gives me the correct hierarchy: clang-check --ast-dump attributeTest.cpp<br>
>><br>
>> TranslationUnitDecl 0x559b4c7dc598 <<invalid sloc>> <invalid sloc><br>
>> |-TypedefDecl 0x559b4c7dce70 <<invalid sloc>> <invalid sloc> implicit __int128_t '__int128'<br>
>> | `-BuiltinType 0x559b4c7dcb30 '__int128'<br>
>> |-TypedefDecl 0x559b4c7dced8 <<invalid sloc>> <invalid sloc> implicit __uint128_t 'unsigned __int128'<br>
>> | `-BuiltinType 0x559b4c7dcb50 'unsigned __int128'<br>
>> |-TypedefDecl 0x559b4c7dd208 <<invalid sloc>> <invalid sloc> implicit __NSConstantString '__NSConstantString_tag'<br>
>> | `-RecordType 0x559b4c7dcfb0 '__NSConstantString_tag'<br>
>> | `-CXXRecord 0x559b4c7dcf28 '__NSConstantString_tag'<br>
>> |-TypedefDecl 0x559b4c7dd2a0 <<invalid sloc>> <invalid sloc> implicit __builtin_ms_va_list 'char *'<br>
>> | `-PointerType 0x559b4c7dd260 'char *'<br>
>> | `-BuiltinType 0x559b4c7dc630 'char'<br>
>> |-TypedefDecl 0x559b4c818958 <<invalid sloc>> <invalid sloc> implicit __builtin_va_list '__va_list_tag [1]'<br>
>> | `-ConstantArrayType 0x559b4c818900 '__va_list_tag [1]' 1<br>
>> | `-RecordType 0x559b4c7dd380 '__va_list_tag'<br>
>> | `-CXXRecord 0x559b4c7dd2f0 '__va_list_tag'<br>
>> `-FunctionDecl 0x559b4c818a98 </home/msagebaum/Kaiserslautern/Programms/adDSLParser/temp/attributeTest.cpp:1:1, line:4:1> line:1:6 func1 'void ()'<br>
>> |-CompoundStmt 0x559b4c818cb0 <line:2:36, line:4:1><br>
>> | `-DeclStmt 0x559b4c818c98 <line:3:3, col:16><br>
>> | `-VarDecl 0x559b4c818bd8 <col:3, col:15> col:7 a 'int' cinit<br>
>> | `-BinaryOperator 0x559b4c818c78 <col:11, col:15> 'int' '+'<br>
>> | |-IntegerLiteral 0x559b4c818c38 <col:11> 'int' 1<br>
>> | `-IntegerLiteral 0x559b4c818c58 <col:15> 'int' 1<br>
>> `-AnnotateAttr 0x559b4c818b30 <line:2:14, col:32> "Test"<br>
>><br>
>><br>
>> If I now run the file through my AST Visitor: (parserTest.cpp)<br>
>><br>
>> #include <iostream><br>
>><br>
>> #include "clang/AST/ASTConsumer.h"<br>
>> #include "clang/AST/QualTypeNames.h"<br>
>> #include "clang/AST/RecursiveASTVisitor.h"<br>
>> #include "clang/Frontend/CompilerInstance.h"<br>
>> #include "clang/Frontend/FrontendAction.h"<br>
>> #include "clang/Tooling/CommonOptionsParser.h"<br>
>> #include "clang/Tooling/Tooling.h"<br>
>><br>
>> #include <llvm/Support/CommandLine.h><br>
>><br>
>> using namespace llvm;<br>
>> using namespace clang;<br>
>> using namespace clang::tooling;<br>
>><br>
>> class XMLGenerator : public RecursiveASTVisitor<XMLGenerator> {<br>
>> public:<br>
>><br>
>> bool TraverseFunctionDecl(FunctionDecl *declaration) {<br>
>><br>
>> std::cout << "Function start" << std::endl;<br>
>><br>
>> RecursiveASTVisitor<XMLGenerator>::TraverseFunctionDecl(declaration);<br>
>><br>
>> std::cout << "Function end" << std::endl;<br>
>> return true;<br>
>> }<br>
>><br>
>> bool TraverseAnnotateAttr(AnnotateAttr *a) {<br>
>> std::cout << "Annotation start" << std::endl;<br>
>><br>
>> RecursiveASTVisitor<XMLGenerator>::TraverseAnnotateAttr(a);<br>
>><br>
>> std::cout << "Annotation end" << std::endl;<br>
>> return true;<br>
>> }<br>
>> };<br>
>><br>
>> class XMLGeneratorClassConsumer : public clang::ASTConsumer {<br>
>> public:<br>
>> explicit XMLGeneratorClassConsumer()<br>
>> : Visitor() {}<br>
>><br>
>> virtual void HandleTranslationUnit(clang::ASTContext &Context) {<br>
>> Visitor.TraverseDecl(Context.getTranslationUnitDecl());<br>
>> }<br>
>> private:<br>
>> XMLGenerator Visitor;<br>
>> };<br>
>><br>
>> class XMLGeneratorClassAction : public clang::ASTFrontendAction {<br>
>> public:<br>
>> virtual std::unique_ptr<clang::ASTConsumer> CreateASTConsumer(<br>
>> clang::CompilerInstance &Compiler, llvm::StringRef InFile) {<br>
>> return std::unique_ptr<clang::ASTConsumer>(<br>
>> new XMLGeneratorClassConsumer());<br>
>> }<br>
>> };<br>
>><br>
>> static llvm::cl::OptionCategory MyToolCategory("my-tool options");<br>
>><br>
>> int main(int argc, const char **argv) {<br>
>> CommonOptionsParser OptionsParser(argc, argv, MyToolCategory);<br>
>> ClangTool Tool(OptionsParser.getCompilations(),<br>
>> OptionsParser.getSourcePathList());<br>
>><br>
>> return Tool.run(newFrontendActionFactory<XMLGeneratorClassAction>().get());<br>
>> }<br>
>><br>
>><br>
>> Compilation: (compile.sh)<br>
>><br>
>> g++ -g -O0 -Wall -pedantic -std=c++11 -fno-rtti -c parserTest.cpp -o parserTest.o -I/usr/include<br>
>> g++ -g -O0 -Wall -pedantic -std=c++11 -fno-rtti -o parserTest.exe parserTest.o -L/usr/lib64 -Wl,--start-group -lclangAnalysis -lclangParse -lclangEdit -lclangSema -lclangTooling -lclangDriver -lclangSerialization -lclangFrontend -lclangBasic -lclangASTMatchers -lclangAST -lclangLex -lLLVM-8 -Wl,--end-group -lpthread -lz<br>
>><br>
>><br>
>> The result is:<br>
>><br>
>> Function start<br>
>> Function end<br>
>> Annotation start<br>
>> Annotation end<br>
>><br>
>><br>
>> What I would expect is:<br>
>><br>
>> Function start<br>
>> Annotation start<br>
>> Annotation end<br>
>> Function end<br>
>><br>
>><br>
>> My questions are now:<br>
>> Is the order provided by my implementation the correct one or is the expected order the correct one?<br>
>> Is there a way to change the visitor order such that attributes are visited inside of the function?<br>
>> If not: Is there a way to get a list of attributes from 'FunctionDecl'? (Could not find any methods in the api <a href="https://clang.llvm.org/doxygen/classclang_1_1FunctionDecl.html" rel="noreferrer" target="_blank">https://clang.llvm.org/doxygen/classclang_1_1FunctionDecl.html</a>)<br>
>><br>
>> Thanks in advance for any help.<br>
>><br>
>> Cheers<br>
>><br>
>> Max<br>
>> _______________________________________________<br>
>> cfe-dev mailing list<br>
>> <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
>><br>
>><br>
>><br>
>> --<br>
>><br>
>> Dr. Max Sagebaum<br>
>><br>
>> Chair for Scientific Computing,<br>
>> TU Kaiserslautern,<br>
>> Bldg/Geb 34, Paul-Ehrlich-Strasse,<br>
>> 67663 Kaiserslautern, Germany<br>
>><br>
>> Phone: +49 (0)631 205 5638<br>
>> Fax: +49 (0)631 205 3056<br>
>> Email: <a href="mailto:max.sagebaum@scicomp.uni-kl.de" target="_blank">max.sagebaum@scicomp.uni-kl.de</a><br>
>> URL: <a href="http://www.scicomp.uni-kl.de" rel="noreferrer" target="_blank">www.scicomp.uni-kl.de</a><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
><br>
><br>
> --<br>
> Regards,<br>
> Ilya Biryukov<br>
> _______________________________________________<br>
> cfe-dev mailing list<br>
> <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Regards,</div><div>Ilya Biryukov</div></div></div></div></div>