<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 4/18/19 10:54 AM, Kristóf Umann
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAGcXOD59KFm=b6iQ5-Vw=_v7uHu=CJLRYrk69Amxa+r9a6ekpQ@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div>Hi!<br>
<br>
Just a quick question, I'm planning to land <a
href="https://reviews.llvm.org/D57855"
moz-do-not-send="true">https://reviews.llvm.org/D57855</a>:
"[analyzer][NFC] Reimplement checker options", as it seems
like there is a general consensus in the community that
it's looking great. However, some checker option
descriptions are missing, and I couldn't manage to figure
them out on my own, could you help me with that please?<br>
<ul>
<li class="gmail-remarkup-list-item"
style="margin:0px;padding:0px;border:0px;line-height:1.7em"><tt class="gmail-remarkup-monospaced" style="color:rgb(0,0,0);background:rgba(71,87,120,0.1);padding:1px 4px;border-radius:3px;white-space:pre-wrap;margin-top:0px">nullability:NoDiagnoseCallsToSystemHeaders</tt></li>
</ul>
</div>
</div>
</div>
</div>
</blockquote>
<br>
That's what the comment says, i guess i can't add much to it:<br>
<br>
88 // If true, the checker will not diagnose nullabilility
issues for calls<br>
89 // to system headers. This option is motivated by the
observation that large<br>
90 // projects may have many nullability warnings. These
projects may<br>
91 // find warnings about nullability annotations that they
have explicitly<br>
92 // added themselves higher priority to fix than warnings on
calls to system<br>
93 // libraries.<br>
<br>
I.e., something like<br>
"""<br>
Suppresses warnings for violating nullability annotations of system
header functions. This is useful if you are concerned with your
custom nullability annotations more than with following nullability
specifications of system header functions.<br>
"""<br>
<blockquote type="cite"
cite="mid:CAGcXOD59KFm=b6iQ5-Vw=_v7uHu=CJLRYrk69Amxa+r9a6ekpQ@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div>
<ul>
<li class="gmail-remarkup-list-item"
style="margin:0px;padding:0px;border:0px;line-height:1.7em"><tt class="gmail-remarkup-monospaced" style="color:rgb(0,0,0);background:rgba(71,87,120,0.1);padding:1px 4px;border-radius:3px;white-space:pre-wrap;margin-top:0px">osx.cocoa.RetainCount:CheckOSObject</tt></li>
</ul>
</div>
</div>
</div>
</div>
</blockquote>
<br>
"""<br>
Find violations of retain-release rules applied to XNU OSObject
instances. By default, the checker only checks retain-release rules
for Objective-C NSObject instances and CoreFoundation objects.<br>
"""<br>
<blockquote type="cite"
cite="mid:CAGcXOD59KFm=b6iQ5-Vw=_v7uHu=CJLRYrk69Amxa+r9a6ekpQ@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div>
<ul>
<li class="gmail-remarkup-list-item"
style="margin:0px;padding:0px;border:0px;line-height:1.7em"><tt class="gmail-remarkup-monospaced" style="color:rgb(0,0,0);background:rgba(71,87,120,0.1);padding:1px 4px;border-radius:3px;white-space:pre-wrap;margin-top:0px">osx.cocoa.RetainCount:leak-diagnostics-reference-allocation</tt></li>
</ul>
</div>
</div>
</div>
</div>
</blockquote>
<br>
This one was removed in r348637 :)<br>
<br>
<blockquote type="cite"
cite="mid:CAGcXOD59KFm=b6iQ5-Vw=_v7uHu=CJLRYrk69Amxa+r9a6ekpQ@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div>
<ul>
<li class="gmail-remarkup-list-item"
style="margin:0px;padding:0px;border:0px;line-height:1.7em"><tt class="gmail-remarkup-monospaced" style="color:rgb(0,0,0);background:rgba(71,87,120,0.1);padding:1px 4px;border-radius:3px;white-space:pre-wrap;margin-top:0px">osx.cocoa.RetainCount:TrackNSCFStartParam</tt></li>
</ul>
</div>
</div>
</div>
</div>
</blockquote>
<br>
"""<br>
Check not only that the code follows retain-release rules with
respect to objects it allocates or borrows from elsewhere, but also
that it fulfills its own retain count specification with respect to
objects that it receives as arguments.<br>
"""<br>
<br>
<blockquote type="cite"
cite="mid:CAGcXOD59KFm=b6iQ5-Vw=_v7uHu=CJLRYrk69Amxa+r9a6ekpQ@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div>Cheers!<br>
</div>
<div>Kristóf</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>