<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>I think there could be two modes in which clang-tidy is being
run.</p>
<p>For new code seeing these violations would be great, but they
could be run as linter in `arc`, for existing code this is of
course<br>
another thing.</p>
<p>In my opinion we should lint new code better and have clang-tidy
run there at least with full configuration enabled.<br>
</p>
<div class="moz-cite-prefix">Am 01.02.19 um 12:21 schrieb Ilya
Biryukov via cfe-dev:<br>
</div>
<blockquote type="cite"
cite="mid:CANmbtFeTOC=GubuSOxZK7naauq68NjNxnKBSbo+1kwqo70jyAw@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">We disabled the two most noisy checks in r352862
and clang-tidy now produces only 3 warnings on Sema.h.</div>
<div>Let us know if you have concerns and feel we should revert
this.</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Jan 29, 2019 at 6:03
PM Ilya Biryukov <<a href="mailto:ibiryukov@google.com"
moz-do-not-send="true">ibiryukov@google.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi cfe-dev,
<div><br>
</div>
<div>Clangd started showing clang-tidy warnings
recently and I've noticed there is too much of by
clang-tidy inside the clang codebase, and most of it
is coming from 'readability-identifier-naming' check
(at least in the Sema and Parser code).</div>
<div><br>
</div>
<div>E.g. running </div>
<div>./bin/clang-tidy
../llvm/clang/lib/Parse/ParseExpr.cpp<br>
</div>
<div><br>
</div>
<div>produces produces 52 warnings, 51 of which are
naming violations from
'readability-identifier-naming'. 'Sema.h' has 1830
clang-tidy warnings with
'readability-identifier-naming' and 228 without it.</div>
<div><br>
</div>
<div>IIUC, the consensus is that renaming everything
to align with the style guide is just not worth it
(would introduce merge conflicts, mess up the
history, etc). Does this render the naming check
non-useful for the 'clang/' project? Should we
remove it from 'clang/.clang-tidy'?</div>
<div><br>
</div>
<div>Are there other alternatives that could bring
down the noise in clang-tidy output and actually
make it useful (e.g. we could put a file-wide NOLINT
comments into those files)?</div>
<div>
<div><br>
</div>
-- <br>
<div dir="ltr"
class="gmail-m_-9075955272548244643gmail-m_-8980937222283393064gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>Regards,</div>
<div>Ilya Biryukov</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>Regards,</div>
<div>Ilya Biryukov</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
cfe-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
</body>
</html>