<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 7, 2018, at 11:26 AM, Kristóf Umann via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class="">Hi!<br class=""><br class="">I have two questions about this topic.</div><div dir="ltr" class=""><br class=""></div><div dir="ltr" class="">1. Checker registration:<br class=""><br class="">I am in the process of updating <a href="http://clang-analyzer.llvm.org/" target="_blank" class="">clang-analyzer.llvm.org</a>, and as I went through the checkers that were missing, I encountered this:</div><div dir="ltr" class=""><div dir="ltr" class=""><br class=""></div><div dir="ltr" class=""><font face="monospace, monospace" class="">def NonnullGlobalConstantsChecker: Checker<"NonnilStringConstants">,</font></div><div dir="ltr" class=""><font face="monospace, monospace" class=""> HelpText<"Assume that const string-like globals are non-null">,</font></div><div dir="ltr" class=""><font face="monospace, monospace" class=""> DescFile<"NonilStringConstantsChecker.cpp">;</font></div></div><div dir="ltr" class=""><span style="color:rgb(36,41,46);font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;white-space:pre-wrap" class=""><br class=""></span></div><div class=""><font color="#24292e" face="arial, helvetica, sans-serif" class=""><span style="font-size:12px;white-space:pre-wrap" class="">What is particularly interesting here (other than the mismatched names), is that </span></font><span style="color:rgb(36,41,46);font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;white-space:pre-wrap" class="">NonilStringConstantsChecker.cpp </span><span style="color:rgb(36,41,46);font-size:12px;white-space:pre-wrap" class=""><font face="arial, helvetica, sans-serif" class="">doesn't exist, in fact it never did. To my greatest surprise, DescFile isn't used anywhere!</font></span></div><div class=""><font color="#24292e" face="monospace, monospace" class=""><span style="font-size:12px;white-space:pre-wrap" class=""><br class=""></span></font></div><div class=""><font color="#24292e" face="monospace, monospace" class=""><span style="font-size:12px;white-space:pre-wrap" class="">#define CHECKER(FULLNAME,CLASS,DESCFILE,HELPTEXT,GROUPINDEX,HIDDEN) \
registry.addChecker(register##CLASS, FULLNAME, HELPTEXT);</span></font>
</div><div class=""><span style="color:rgb(36,41,46);font-size:12px;white-space:pre-wrap" class=""><font face="arial, helvetica, sans-serif" class=""><br class=""></font></span></div><div class=""><font color="#24292e" face="arial, helvetica, sans-serif" class=""><span style="font-size:12px;white-space:pre-wrap" class="">So, is there a point in keeping DescFile entries?</span></font></div></div></div></div></div></blockquote><div><br class=""></div><div>Just to give some context for ‘<span style="white-space: pre-wrap; color: rgb(36, 41, 46); font-family: arial, helvetica, sans-serif;" class="">DescFile'</span>, the intention of this was to point to a file that we could use to add detailed documentation for a checker with a specific format, think of something like extensive doxygen documentation, and a tool would be able to extract such detailed documentation from the source files and render them in another format, like html pages for <span style="-webkit-text-stroke-width: initial; text-decoration: underline; -webkit-font-kerning: none;" class=""><font color="#3586ff" class=""><span style="-webkit-text-stroke-color: rgb(53, 134, 255);" class=""><a href="http://clang-analyzer.llvm.org" class="">clang-analyzer.llvm.org</a></span></font><font color="#453ccc" class=""><span style="caret-color: rgb(69, 60, 204); -webkit-text-stroke-color: rgb(69, 60, 204);" class="">.</span></font></span></div><div><br class=""></div><div>However, this never materialized and it’s useless now.</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div class=""><font color="#24292e" face="arial, helvetica, sans-serif" class=""><span style="font-size:12px;white-space:pre-wrap" class=""><br class=""></span></font></div><div class=""><font color="#24292e" face="arial, helvetica, sans-serif" class=""><span style="font-size:12px;white-space:pre-wrap" class="">2. Use tblgen for AnalyzerOptions:</span></font></div><div class=""><font color="#24292e" face="arial, helvetica, sans-serif" class=""><span style="font-size:12px;white-space:pre-wrap" class=""><br class=""></span></font></div><div class=""><font color="#24292e" class=""><span style="font-size:12px;white-space:pre-wrap" class=""><font face="arial, helvetica, sans-serif" class="">I dislike that I need to look at source code, or doxygen at best to know what kind </font><font face="monospace, monospace" class="">-analyzer-config </font><font face="arial, helvetica, sans-serif" class="">options are </font></span></font><font color="#24292e" face="arial, helvetica, sans-serif" class=""><span style="font-size:12px;white-space:pre-wrap" class="">available. Would it be a good idea for me to refactor it with tblgen?</span></font></div><div class=""><font color="#24292e" face="arial, helvetica, sans-serif" class=""><span style="font-size:12px;white-space:pre-wrap" class=""><br class=""></span></font></div><div class=""><font color="#24292e" face="arial, helvetica, sans-serif" class=""><span style="font-size:12px;white-space:pre-wrap" class="">Cheers,</span></font></div><div class="">Kristóf</div></div></div></div>
_______________________________________________<br class="">cfe-dev mailing list<br class=""><a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev<br class=""></div></blockquote></div><br class=""></body></html>