<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
code
{mso-style-priority:99;
font-family:"Courier New";}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
p.m8156414438164410437msoplaintext, li.m8156414438164410437msoplaintext, div.m8156414438164410437msoplaintext
{mso-style-name:m_8156414438164410437msoplaintext;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Thanks Owen.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Given a class definition:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";color:#0000B0">class</span><span style="font-size:10.0pt;font-family:"Courier New";color:black"> Rectangle {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";color:black">
</span><span style="font-size:10.0pt;font-family:"Courier New";color:#0000B0">public</span><span style="font-size:10.0pt;font-family:"Courier New";color:black">:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";color:black"> Rectangle(</span><span style="font-size:10.0pt;font-family:"Courier New";color:#0000B0">int</span><span style="font-size:10.0pt;font-family:"Courier New";color:black">,</span><span style="font-size:10.0pt;font-family:"Courier New";color:#0000B0">int</span><span style="font-size:10.0pt;font-family:"Courier New";color:black">);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";color:black">
</span><span style="font-size:10.0pt;font-family:"Courier New";color:#0000B0">int</span><span style="font-size:10.0pt;font-family:"Courier New";color:black"> area();<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";color:black">
</span><span style="font-size:10.0pt;font-family:"Courier New";color:#0000B0">private</span><span style="font-size:10.0pt;font-family:"Courier New";color:black">:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";color:black"> int m_width = 0;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";color:black"> int m_height = 0<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";color:black"> double m_cornerRadius = 0;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New";color:black">};</span><span style="font-size:9.0pt;font-family:"Courier New";color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’m speaking of aligning the class members <i>only</i> (w/h/cornerradius above).<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">We use clang-format to check that all developers code matches our coding conventions before they check-in, that’s all I meant by validation. If their code doesn’t match the rules we’ve setup, we use clang-format to auto-fix. The problem
is with <b><span style="font-family:"Courier New";color:#333333;background:white">AlignConsecutiveDeclarations
</span></b>it aligns these but also many other things (basically any declaration), which is not what we want.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Owen Pan <owenpiano@gmail.com><br>
<b>Date: </b>Wednesday, September 19, 2018 at 10:05 PM<br>
<b>To: </b>"clucier@adobe.com" <clucier@adobe.com><br>
<b>Cc: </b>"cfe-dev@lists.llvm.org" <cfe-dev@lists.llvm.org><br>
<b>Subject: </b>Re: [cfe-dev] Clang-format Inquiry - Member Alignment<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><a name="_MailOriginalBody">On Wed, Sep 19, 2018 at 11:34 AM Corey Lucier via cfe-dev <</a><a href="mailto:cfe-dev@lists.llvm.org"><span style="mso-bookmark:_MailOriginalBody">cfe-dev@lists.llvm.org</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody">>
wrote:<o:p></o:p></span></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New"">Thank you in advance for any assistance, this is my first cfe-dev list post, apologies for any disruption.</span><o:p></o:p></span></p>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New""> </span><o:p></o:p></span></p>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New"">We use clang-format to lint our C++ as well as “auto-fix” as necessary.
</span><o:p></o:p></span></p>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New""> </span><o:p></o:p></span></p>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New"">There is one coding convention which we had to lose given the fact that it seems clang-format doesn’t have any options we can use
to allow for it. Specifically C++ class member alignment.</span><o:p></o:p></span></p>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New""> </span><o:p></o:p></span></p>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New"">We want to for example be able to format our class members for easier scanning/readability as follows:</span><o:p></o:p></span></p>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New""> </span><o:p></o:p></span></p>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New"">TypeA m_memberOne;</span><o:p></o:p></span></p>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New"">LongTypeB* m_memberTwo = nullptr;</span><o:p></o:p></span></p>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New"">bool m_someFlag = false;</span><o:p></o:p></span></p>
<p class="m8156414438164410437msoplaintext"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New""> </span><o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New"">Unfortunately if we for example make use of
<b><span style="color:#333333;background:white">AlignConsecutiveDeclarations</span></b><span style="color:#333333;background:white"> local method definitions become aligned as well as locally declared functions, etc.</span></span><o:p></o:p></span></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"><o:p> </o:p></span></p>
</div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody">Can you use a code snippet to elaborate what you mean and want here? Are you referring to member functions defined and declared in the class declaration, respectively?<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"><o:p> </o:p></span></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New";color:#333333;background:white"> </span><o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"><span style="font-family:"Courier New";color:#333333;background:white">Is there any current mechanism to allow for class member declaration
alignment and validation?</span><o:p></o:p></span></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody">What does validation mean?<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody">Thanks,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody">Owen<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>