<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>my vote: true for success, false for failure<br>
</p>
<p>Philip<br>
</p>
<br>
<div class="moz-cite-prefix">On 09/17/2018 10:57 AM, Nico Weber via
llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAMGbLiHo=9qPmT=bEJuzgbhFC1c=WFrOLhM_1BaKJC5gznHxGA@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi,
<div><br>
</div>
<div>in <a href="https://reviews.llvm.org/D52143"
moz-do-not-send="true">https://reviews.llvm.org/D52143</a>
there's some uncertainty if LLVM code prefers</div>
<div><br>
</div>
<div> if (!Function())</div>
<div> // Call to function failed, deal with it</div>
<div><br>
</div>
<div>or</div>
<div><br>
</div>
<div>
<div> if (Function())</div>
<div> // Call to function failed, deal with it</div>
</div>
<div><br>
</div>
<div>(Note that this is about functions returning bool,
not int.)<br>
</div>
<div><br>
</div>
<div>Folks on that review feel that returning true on
success is probably what we want, but it's not
documented anywhere and we do have both forms in the
codebase.</div>
<div><br>
True on success seems more common:</div>
<div><a
href="http://llvm-cs.pcc.me.uk/?q=true+on+success"
moz-do-not-send="true">http://llvm-cs.pcc.me.uk/?q=true+on+success</a><br>
</div>
<div><a href="http://llvm-cs.pcc.me.uk/?q=true+on+error"
moz-do-not-send="true">http://llvm-cs.pcc.me.uk/?q=true+on+error</a><br>
</div>
<div><br>
</div>
<div>Does anyone have a pointer to previous on-list
discussion on this? If not, this thread could be the
place where we sort this out once and for all :-)</div>
<div><br>
</div>
<div>Apologies for the bike-sheddy topic.</div>
<div><br>
</div>
<div>Nico</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>