<div dir="ltr">The patch was a baby step in right direction, but it does not function properly. Let me try to make it work, I'll post it then.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 11, 2018 at 3:12 AM, Jonas Toth via cfe-dev <span dir="ltr"><<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>Hi Oleg,</p>
<p>could you please send that patch to `<a href="http://reviews.llvm.org" target="_blank">reviews.llvm.org</a>`. That
makes it easier to review and discuss on the code.</p>
<p>Best, Jonas<br>
</p><div><div class="h5">
<br>
<div class="m_-7639629267501628625moz-cite-prefix">Am 10.09.2018 um 22:47 schrieb Oleg
Smolsky via cfe-dev:<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">OK,
the functionality is a special case introduced in 2014 here:
8228889b01404d7e59270b1f97a839<wbr>77531a7748.
<br>
<br>
The minimal hack is to check for the preceding comma... but that
breaks some "literal" cases... So, I need to make these selections
even more particular (to either exclude literals or only include
lambdas). Does this sound right?
<br>
<br>
On 2018-09-10 12:47, Oleg Smolsky wrote:
<br>
<blockquote type="cite">Hi, I've just boiled down an interesting
C++ lambda formatting trait and would like to clarify the tool's
behavior. Consider the following snippet (please view with a
fixed-width font):
<br>
<br>
void f() {
<br>
something->One(
<br>
[this] {
<br>
Do1();
<br>
Do2();
<br>
},
<br>
1);
<br>
something->Two(1,
<br>
[this] {
<br>
Do1();
<br>
Do2();
<br>
},
<br>
1);
<br>
}
<br>
<br>
There is an inconsistency in the way lambda args are formatted,
depending on whether it is first (the "One()" call above) or not
(the "Two()" call above). Is there some internal guide that the
tool uses to decide between the two layouts? Or is it just an
artifact of the implementation?
<br>
<br>
More generally, would you entertain a patch that forces the
format one way or another? (Perhaps even with a user-defined
setting?)
<br>
<br>
Thanks,
<br>
Oleg.
<br>
<br>
</blockquote>
<br>
<fieldset class="m_-7639629267501628625mimeAttachmentHeader"></fieldset>
<br>
</div></div><pre>______________________________<wbr>_________________
cfe-dev mailing list
<a class="m_-7639629267501628625moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>
<a class="m_-7639629267501628625moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
<br>
</div>
<br>______________________________<wbr>_________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><span style="line-height:18px"><span style="font-family:helvetica;font-size:12px"><strong>Oleg Smolsky <br></strong></span><span style="font-family:helvetica;font-size:12px">Member of Technical Staff</span></span><span style="font-family:helvetica;font-size:12px;line-height:18px"><br><a href="https://twitter.com/cohesity" style="font-family:helvetica;font-size:12px;line-height:18px" target="_blank"><img src="https://d23fetfglg1ija.cloudfront.net/signature_fields/57d8328c0e0f757f6ec665ba/twitter-3-16.png" border="0" alt="twitter-3-16.png"></a> <a href="https://www.linkedin.com/company/cohesity" style="font-family:helvetica;font-size:12px;line-height:18px" target="_blank"><img src="https://d23fetfglg1ija.cloudfront.net/signature_fields/57d8328c0e0f757f6ec665ba/linkedin-6-16.png" border="0" alt="linkedin-6-16.png"></a><br><br><a href="http://signatures.cohesity.com/uc/57f5aca20e0f7567c3300bbe" style="font-family:helvetica;font-size:12px;line-height:18px" target="_blank"><img src="http://signatures.cohesity.com/uc/57f5aca20e0f7567c3300bbe/img.png" border="0" alt="" style="color:blue;font-family:"Helvetica";font-size:12px"></a><br></span></div>
</div>