<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:odc="urn:schemas-microsoft-com:office:odc" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc="http://microsoft.com/officenet/conferencing" xmlns:D="DAV:" xmlns:Repl="http://schemas.microsoft.com/repl/" xmlns:mt="http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ppda="http://www.passport.com/NameSpace.xsd" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcs="http://schemas.microsoft.com/data/udc/soap" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p="http://schemas.microsoft.com/data/udc/parttopart" xmlns:wf="http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:dsss="http://schemas.microsoft.com/office/2006/digsig-setup" xmlns:dssi="http://schemas.microsoft.com/office/2006/digsig" xmlns:mdssi="http://schemas.openxmlformats.org/package/2006/digital-signature" xmlns:mver="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels="http://schemas.openxmlformats.org/package/2006/relationships" xmlns:spwp="http://microsoft.com/sharepoint/webpartpages" xmlns:ex12t="http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m="http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:pptsl="http://schemas.microsoft.com/sharepoint/soap/SlideLibrary/" xmlns:spsl="http://microsoft.com/webservices/SharePointPortalServer/PublishedLinksService" xmlns:Z="urn:schemas-microsoft-com:" xmlns:tax="http://schemas.microsoft.com/sharepoint/taxonomy/soap/" xmlns:tns="http://schemas.microsoft.com/sharepoint/soap/recordsrepository/" xmlns:spsup="http://microsoft.com/webservices/SharePointPortalServer/UserProfileService" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:st="" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">This test, and a few others, dump what is essentially binary data to stdout. This data trips up the cmake-detected Python interpreter (2.7.6) and causes the following error with a check-all build of LLVM:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Traceback (most recent call last):<o:p></o:p></p>
<p class="MsoNormal"> File "<path>/llvm-lit", line 37, in <module><o:p></o:p></p>
<p class="MsoNormal"> main(builtin_parameters)<o:p></o:p></p>
<p class="MsoNormal"> File "llvm/utils/lit/lit/main.py", line 193, in main<o:p></o:p></p>
<p class="MsoNormal"> main_with_tmp(builtinParameters)<o:p></o:p></p>
<p class="MsoNormal"> File "llvm/utils/lit/lit/main.py", line 540, in main_with_tmp<o:p></o:p></p>
<p class="MsoNormal"> write_test_results(run, litConfig, testing_time, opts.output_path)<o:p></o:p></p>
<p class="MsoNormal"> File "llvm/utils/lit/lit/main.py", line 153, in write_test_results<o:p></o:p></p>
<p class="MsoNormal"> json.dump(data, f, indent=2, sort_keys=True)<o:p></o:p></p>
<p class="MsoNormal"> File "/usr/lib/python2.7/json/__init__.py", line 189, in dump<o:p></o:p></p>
<p class="MsoNormal"> for chunk in iterable:<o:p></o:p></p>
<p class="MsoNormal"> File "/usr/lib/python2.7/json/encoder.py", line 434, in _iterencode<o:p></o:p></p>
<p class="MsoNormal"> for chunk in _iterencode_dict(o, _current_indent_level):<o:p></o:p></p>
<p class="MsoNormal"> File "/usr/lib/python2.7/json/encoder.py", line 408, in _iterencode_dict<o:p></o:p></p>
<p class="MsoNormal"> for chunk in chunks:<o:p></o:p></p>
<p class="MsoNormal"> File "/usr/lib/python2.7/json/encoder.py", line 332, in _iterencode_list<o:p></o:p></p>
<p class="MsoNormal"> for chunk in chunks:<o:p></o:p></p>
<p class="MsoNormal"> File "/usr/lib/python2.7/json/encoder.py", line 390, in _iterencode_dict<o:p></o:p></p>
<p class="MsoNormal"> yield _encoder(value)<o:p></o:p></p>
<p class="MsoNormal">UnicodeDecodeError: 'utf8' codec can't decode byte 0xce in position 2685: invalid continuation byte<o:p></o:p></p>
<p class="MsoNormal">ninja: build stopped: subcommand failed.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This test has existed in a similar format since it was committed 4 years ago.<o:p></o:p></p>
<p class="MsoNormal">I can reproduce this with the following directed llvm-lit invocation:<o:p></o:p></p>
<p class="MsoNormal" style="text-indent:.5in">/path/to/llvm/bin/llvm-lit --output=a.json /path/to/clang/ --filter=macro-undef<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Has anyone run into this issue before? It seems unlikely that no one has tried to dump the output of this test to a JSON file in 4 years, so I’m open to suggestions as to what I might be doing wrong.<o:p></o:p></p>
<p class="MsoNormal">Since the test does not attempt to use the result of the RUN, I have been able to ‘fix’ the issue with the following minor patch:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">diff --git a/test/Modules/macro-undef-through-pch.m b/test/Modules/macro-undef-through-pch.m<o:p></o:p></p>
<p class="MsoNormal">index fc32229bec..c4ea3fb98a 100644<o:p></o:p></p>
<p class="MsoNormal">--- a/test/Modules/macro-undef-through-pch.m<o:p></o:p></p>
<p class="MsoNormal">+++ b/test/Modules/macro-undef-through-pch.m<o:p></o:p></p>
<p class="MsoNormal">@@ -3,7 +3,7 @@<o:p></o:p></p>
<p class="MsoNormal">// RUN: -I%S/Inputs/macro-undef-through-pch -emit-pch \<o:p></o:p></p>
<p class="MsoNormal">// RUN: %S/Inputs/macro-undef-through-pch/foo.h -o %t.pch<o:p></o:p></p>
<p class="MsoNormal">// RUN: %clang_cc1 -x objective-c -fmodules -fimplicit-module-maps -fmodules-cache-path=%t \<o:p></o:p></p>
<p class="MsoNormal">-// RUN: -I%S/Inputs/macro-undef-through-pch -emit-pch \<o:p></o:p></p>
<p class="MsoNormal">+// RUN: -I%S/Inputs/macro-undef-through-pch -emit-pch -o %t.dummy.pch \<o:p></o:p></p>
<p class="MsoNormal">// RUN: -include-pch %t.pch %s<o:p></o:p></p>
<p class="MsoNormal"><o:p></o:p></p>
<p class="MsoNormal"> // PR19215<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">J.B. Nagurne<o:p></o:p></p>
<p class="MsoNormal">Code Generation<o:p></o:p></p>
<p class="MsoNormal">Texas Instruments<o:p></o:p></p>
</div>
</body>
</html>