<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Aug 20, 2018 at 7:24 AM Oren Ish-Shalom via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi all,<div><br></div><div><a href="https://stackoverflow.com/questions/51929037/llvm-coding-style-regarding-consecutive-angle-brackets-in-templates?noredirect=1#comment90813882_51929037" target="_blank">This SO post</a> is regarding the status of consecutive angle brackets in templates.</div><div>I'm writing here too, hoping to get a certified answer.</div><div><br></div><div>Since it is legal to write:</div><div><br></div><div>    vector<vector<float>> MyMatrix;</div><div><div style="font-size:small;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="font-size:small;text-decoration-style:initial;text-decoration-color:initial">and not just:</div><div style="font-size:small;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="font-size:small;text-decoration-style:initial;text-decoration-color:initial">    // vector<vector<float> > MyMatrix;</div><br></div><div>I was somewhat surprised to find many > > patterns when grepping llvm 6.0.0.</div><div><b><br></b></div><div><b>What are the considerations against sed-replacing all > > with >>?</b></div><div><br></div><div>Is it only the "don't fix it if it's not broken" consideration?</div></div></blockquote><div><br></div><div>Generally - there's some aversion to messing with revision history (as much as revision control systems can see through whitespace changes when blaming, etc) & the like. (same reason we don't just clang-format the whole codebase)<br><br>- Dave</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Thanks!</div></div>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div></div>