<div dir="ltr">Would be nice to get around this limitation in the standard library. I don't think we can do it in a standard-compliant way, though.<div>There's `llvm::llvm_execute_on_thread`, but it is an OS-specific implementation.</div><div><br></div><div>Are there any ways to set default stack sizes for the newly created threads? Even if it's platform-specific code, it should be pretty localized and we could reuse the STL implementation of threads.</div><div>I don't know of reliable APIs to do that, unfortunately.</div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 17, 2018 at 2:43 PM Eric Liu <<a href="mailto:ioeric@google.com">ioeric@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><a class="m_6659629032532660871GWVZpf m_6659629032532660871gW" id="m_6659629032532660871IloFPc-2" href="mailto:clangd-dev@lists.llvm.org" target="_blank">+clangd-dev@lists.llvm.org</a> <a class="m_6659629032532660871GWVZpf m_6659629032532660871gW" id="m_6659629032532660871IloFPc-3" href="mailto:ibiryukov@google.com" target="_blank">+Ilya Biryukov</a> <br></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 17, 2018 at 2:41 PM <a href="mailto:Dmitry.Kozhevnikov@jetbrains.com" target="_blank">Dmitry.Kozhevnikov@jetbrains.com</a> via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello!<br>
<br>
clangd uses std::thread for spawning worker threads to parse files (see AsyncTaskRunner::runAsync in tools/clang/tools/extra/clangd/Threading.cpp). Unfortunately, std::thread lacks the ability to customize the stack size, and the default one might be insufficient for parsing complex source files. For example, on macOS, the default stack size for non-main threads is 512K, so the following code causes a stack overflow (on my machine) with clangd, while being way below the default constexpr evaluation depth threshold:<br>
<br>
constexpr int foo(int x) {<br>
return x == 1 ? 1 : foo(x - 1) + 1;<br>
}<br>
static_assert(foo(50) > 0, "");<br>
<br>
This also can be observed on some real-world projects.<br>
<br>
Do I understand correctly that the only way to fix it would be to abandon std::thread and reimplement the platform-specific thread spawning (using pthreads/WinAPI), or is there another solution available in LLVM/clang codebase?<br>
<br>
Best regards,<br>
Dmitry Kozhevnikov._______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Regards,</div><div>Ilya Biryukov</div></div></div></div></div>