<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Aug 13, 2018 at 12:00 AM Matthieu Brucher via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I think that the override is not an after-the-bug tool, but really a proactive checker.</div></blockquote><div><br></div><div>Right - and this is why it's probably not suitable as a warning, and better suited to being in clang-tidy.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"> It doesn't tell you of a bug, it prevents you for introducing one.<div>On an old code base, that's where I find it the most helpful, when you have to work on it. Without the override, you don't have the certainty of properly updating the APIs (old code base also often miss proper test coverage). With override, before your code changes, you can ensure that you are refactoring the full API.</div><div><br></div><div>Cheers,</div><div><br></div><div>Matthieu</div></div><br><div class="gmail_quote"><div dir="ltr">Le lun. 13 août 2018 à 01:59, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">When I say a "false positive" in this context it's not a case where a warning would suggest override where it would be invalid/incorrect to put ovterride - but that it would suggest the 'override' keyword when it would be benign/when it isn't telling the user there's a bug/mistake here.<br><br>On an old codebase, likely /many/ more missing overrides are there because there was no override keyword when the code was written - most of those missing overrides aren't buggy code. So this warning would cause a lot of cleanup for relatively little bug finding.<br><br>- Dave</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 10, 2018 at 8:36 AM Matthieu Brucher via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes, I have to write an example case!<div>I think the odds of an error with a wrong override are very low. Ont he contrary, I noticed several times errors with missing overrides and APIs moving and wrong arguments.</div><div><br></div><div>Cheers</div></div><br><div class="gmail_quote"><div dir="ltr">Le ven. 10 août 2018 à 15:41, Jonas Toth <<a href="mailto:development@jonas-toth.eu" target="_blank">development@jonas-toth.eu</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>That would be worth a bug-report :)<br>
</p>
<br>
<div class="m_-3658586241058076808m_1424776325935668051m_5045729392956655387m_666166841972145255moz-cite-prefix">Am 10.08.2018 um 15:03 schrieb Matthieu
Brucher:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Hi,</div>
<div><br>
</div>
I have noticed the missing override warning when using virtual
diamond inheritance. In that case, there was no warning
generated.
<div><br>
</div>
<div>Regards,</div>
<div><br>
</div>
<div>Matthieu</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">Le ven. 10 août 2018 à 10:23, Jonas Toth via
cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> a
écrit :<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>Hi,</p>
<p>I experience the override-warning when it was
inconsistent within the class (meaning it has been used at
least once and some places missed it). This measure is
probably to not warn on old code bases.</p>
<p>Could this be the case?</p>
<p>Best, Jonas<br>
</p>
<br>
<div class="m_-3658586241058076808m_1424776325935668051m_5045729392956655387m_666166841972145255m_-3364850341991371744moz-cite-prefix">Am
09.08.2018 um 19:26 schrieb JVApen via cfe-dev:<br>
</div>
<blockquote type="cite">
<div dir="auto">Hello all,
<div dir="auto"><br>
</div>
<div dir="auto">Today we have discovered a case where we
did not have a compiler warning for a missing
override. To verify, we explicitly enabled the warning
with the pragma.</div>
<div dir="auto"><br>
</div>
<div dir="auto">While investigating this in the IDE, we
noticed that the Visual Assist plugin did notice that
missing override. As this uses clang-tidy to determine
this, we were wondering if these differences we
noticed are intentional. If so, is their any
documentation on these differences?</div>
<div dir="auto"><br>
</div>
<div dir="auto">Tnx</div>
</div>
<br>
<fieldset class="m_-3658586241058076808m_1424776325935668051m_5045729392956655387m_666166841972145255m_-3364850341991371744mimeAttachmentHeader"></fieldset>
<br>
<pre>_______________________________________________
cfe-dev mailing list
<a class="m_-3658586241058076808m_1424776325935668051m_5045729392956655387m_666166841972145255m_-3364850341991371744moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>
<a class="m_-3658586241058076808m_1424776325935668051m_5045729392956655387m_666166841972145255m_-3364850341991371744moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
<br>
</div>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="m_-3658586241058076808m_1424776325935668051m_5045729392956655387m_666166841972145255gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>Quantitative analyst, Ph.D.<br>
Blog: <a href="http://blog.audio-tk.com/" target="_blank">http://blog.audio-tk.com/</a><br>
LinkedIn: <a href="http://www.linkedin.com/in/matthieubrucher" target="_blank">http://www.linkedin.com/in/matthieubrucher</a></div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="m_-3658586241058076808m_1424776325935668051m_5045729392956655387gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Quantitative analyst, Ph.D.<br>Blog: <a href="http://blog.audio-tk.com/" target="_blank">http://blog.audio-tk.com/</a><br>LinkedIn: <a href="http://www.linkedin.com/in/matthieubrucher" target="_blank">http://www.linkedin.com/in/matthieubrucher</a></div></div></div></div></div>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="m_-3658586241058076808gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Quantitative analyst, Ph.D.<br>Blog: <a href="http://blog.audio-tk.com/" target="_blank">http://blog.audio-tk.com/</a><br>LinkedIn: <a href="http://www.linkedin.com/in/matthieubrucher" target="_blank">http://www.linkedin.com/in/matthieubrucher</a></div></div></div></div></div>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div></div>