<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks for tracking this Marshall!<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On May 28, 2018, at 5:01 PM, Marshall Clow via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Mon, May 28, 2018 at 2:29 PM, Richard Smith <span dir="ltr" class=""><<a href="mailto:richard@metafoo.co.uk" target="_blank" class="">richard@metafoo.co.uk</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class="">Clang 5 implemented the originally adopted proposal. The behaviour you're referring to was introduced by P0620R0, which I think was not implemented until Clang 6. </div></blockquote><div class=""><br class=""></div><div class="">That would explain what I'm seeing.</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class="">Perhaps we should bump the deduction guides feature test macro version for that paper?</div></blockquote><div class=""><br class=""></div><div class="">I don't see any mention of feature macros in <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline" class="">P0620R0 :-(</span></div><div class=""><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline" class="">Besides, I don't see how it will help now that clang 6 is out there.</span></div></div></div></div></div></blockquote><div><br class=""></div><div>Ouch yeah, fixing the deduction guides would have been nice.</div><div><br class=""></div><div>Looks like latest changes for this came in late 2017 from:</div></div><blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;" class=""><div><div><a href="https://reviews.llvm.org/rL320401" class="">https://reviews.llvm.org/rL320401</a></div></div><div><div><a href="https://reviews.llvm.org/rL316292" class="">https://reviews.llvm.org/rL316292</a></div></div></blockquote><div><div><br class=""></div><div>Was the green dragon bot passing? It’s down now for maintenance, but I expect some of the tests should have been failing before your change.</div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline" class="">-- Marshall</span></div><div class=""><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline" class=""><br class=""></span></div><div class=""><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline" class=""><br class=""></span></div><div class=""><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline" class=""><br class=""></span></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><br class=""><div class="gmail_quote"><div class=""><div class="h5">On 28 May 2018 14:10, "Marshall Clow via cfe-dev" <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank" class="">cfe-dev@lists.llvm.org</a>> wrote:<br type="attribution" class=""></div></div><blockquote class="m_5840849276340986773quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""><div class="h5"><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class="m_5840849276340986773quoted-text">On Mon, May 28, 2018 at 12:51 PM, Marshall Clow <span dir="ltr" class=""><<a href="mailto:mclow.lists@gmail.com" rel="noreferrer" target="_blank" class="">mclow.lists@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class="">This past week, I checked in a bunch of code (and tests) having to do with the deduction guides features of C++17 - adding support for many of the standard library types. Some of the tests started failing - mostly (but not exclusively) on ARM. JF tried to fix some of the tests on Friday, but was not completely successful.</div><div class=""><br class=""></div><div class="">Today, I took a fresh look at the failures, and realized that all but one of them were on bots that were running clang-5. It appears that clang-5 has a bug where it mis-deduces the template arguments when it is handed something that looks like a copy constructor. (Alternately, it implicitly generates an incorrect template deduction guide and uses that.)</div></div></blockquote><div class=""><br class=""></div></div><div class="">Another possible diagnosis is that clang-5 generates no implicit deduction guides - and only uses the explicitly provided ones.</div><div class="m_5840849276340986773signature-text"><div class=""><br class=""></div><div class="">-- Marshall</div></div></div></div></div></div></div><div class="m_5840849276340986773elided-text">
______________________________<wbr class="">_________________<br class="">
cfe-dev mailing list<br class="">
<a href="mailto:cfe-dev@lists.llvm.org" rel="noreferrer" target="_blank" class="">cfe-dev@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-dev</a><br class="">
</div></blockquote></div><br class=""></div>
</blockquote></div><br class=""></div></div>
_______________________________________________<br class="">cfe-dev mailing list<br class=""><a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev<br class=""></div></blockquote></div><br class=""></body></html>