<div dir="ltr">Yes, I'd prefer to take this warning out of -Wextra at least for Clang 6. Hopefully we can find good heuristics to suppress the false positives for Clang 7 and then re-enable it.</div><div class="gmail_extra"><br><div class="gmail_quote">On 16 January 2018 at 09:35, Nico Weber via cfe-dev <span dir="ltr"><<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Wait, wasn't the consensus here to leave the warning out of -Wextra too? Looks like r321691 got that wrong?</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 16, 2018 at 12:04 PM, via cfe-dev <span dir="ltr"><<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">> -----Original Message-----<br>
> From: cfe-dev [mailto:<a href="mailto:cfe-dev-bounces@lists.llvm.org" target="_blank">cfe-dev-bounces@lists.<wbr>llvm.org</a>] On Behalf Of Hans<br>
> Wennborg via cfe-dev<br>
> Sent: Tuesday, January 16, 2018 8:01 AM<br>
> To: Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com" target="_blank">lebedev.ri@gmail.com</a>><br>
> Cc: Marshall Clow <<a href="mailto:mclow.lists@gmail.com" target="_blank">mclow.lists@gmail.com</a>>; Richard Smith <richard-<br>
> <a href="mailto:llvm@metafoo.co.uk" target="_blank">llvm@metafoo.co.uk</a>>; <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>; John McCall<br>
> <<a href="mailto:rjmccall@gmail.com" target="_blank">rjmccall@gmail.com</a>><br>
> Subject: Re: [cfe-dev] -Wtautological-constant-compar<wbr>e issues<br>
><br>
...<br>
<span>> >><br>
> >> Apologies for coming late to the thread.<br>
> > No problem.<br>
> ><br>
> >> What's the status here? Did everything land, and should we merge<br>
> r321691 to 6.0?<br>
> > It landed before branching. I see r321691 in release_60 branch.<br>
> > So nothing do be done here.<br>
><br>
> Ah, right. Thanks for checking! Sorry for the noise.<br>
><br>
<br>
</span>Can we consider <a href="https://reviews.llvm.org/D41727" rel="noreferrer" target="_blank">https://reviews.llvm.org/D4172<wbr>7</a> for inclusion in master and possibly release_60?<br>
<br>
-Brian<br>
<div class="m_4442647227795365439HOEnZb"><div class="m_4442647227795365439h5"><br>
______________________________<wbr>_________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a><br>
</div></div></blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div><br></div>