<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 11 January 2018 at 16:39, Liu, Yaxun (Sam) <span dir="ltr"><<a href="mailto:Yaxun.Liu@amd.com" target="_blank">Yaxun.Liu@amd.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div link="blue" vlink="purple" lang="EN-US">
<div class="m_-9076850807180646997WordSection1">
<p class="MsoNormal">The workgroup size is usually 64 or 128. The number of workgroups can be quite large if the global size is large. If for each local array we waste 124 bytes, the total waste could be quite large, considering local memory is precious resource
for GPU.</p></div></div></blockquote><div><br></div><div>It is, if you have a local argument that is just 4 bytes. But is that really typical practical use-case? Doing a local memory allocation in the first place to store 4 bytes seems a bit excessive.<br><br></div><div>Also, a simplification would be to do something like this:<br><br></div><div>alignment = min(round_to_neareast_power_of_2(size), max_alignment), <br><br>so you either align to the size of the argument [because there is no CL type where the alignment is greater than the size of the type itself], or the maximum alignment. This doesn't require any further arguments to be passed, but</div><div>gives a reasonable alignment. Sure, it's going to align an array of 6 int values to 32 bytes, but it's not the same loss as rounding everything to 128 bytes, and can be done without changing anything.</div><div><br></div><div>--</div><div>Mats<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div link="blue" vlink="purple" lang="EN-US"><div class="m_-9076850807180646997WordSection1"><p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">On the other hand, passing the alignment info and using it is pretty straight forward.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Sam<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><b>From:</b> <a href="mailto:mats.o.petersson@googlemail.com" target="_blank">mats.o.petersson@googlemail.<wbr>com</a> [mailto:<a href="mailto:mats.o.petersson@googlemail.com" target="_blank">mats.o.petersson@<wbr>googlemail.com</a>]
<b>On Behalf Of </b>mats petersson<br>
<b>Sent:</b> Thursday, January 11, 2018 7:47 AM<br>
<b>To:</b> Anastasia Stulova <<a href="mailto:Anastasia.Stulova@arm.com" target="_blank">Anastasia.Stulova@arm.com</a>><br>
<b>Cc:</b> Sumner, Brian <<a href="mailto:Brian.Sumner@amd.com" target="_blank">Brian.Sumner@amd.com</a>>; Liu, Yaxun (Sam) <<a href="mailto:Yaxun.Liu@amd.com" target="_blank">Yaxun.Liu@amd.com</a>>; cfe-dev (<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>) <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>>; Bader, Alexey (<a href="mailto:alexey.bader@intel.com" target="_blank">alexey.bader@intel.com</a>) <<a href="mailto:alexey.bader@intel.com" target="_blank">alexey.bader@intel.com</a>>; nd <<a href="mailto:nd@arm.com" target="_blank">nd@arm.com</a>><br>
<b>Subject:</b> Re: [cfe-dev] [RFC][OpenCL] Pass alignment of arguments in local addr space for device-side enqueued kernel to __enqueue_kernel functions<u></u><u></u></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<div>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">I'm still a little bit confused about the background of this. And I understand that the actual usecase here may not be something that can be shared, but perhaps at least some part of the underlying problem can
be shared to help with the understanding of the issue is here... <u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt">The approach I've taken is to allocate every local argument with the "largest alignment requirement" (in other words 128 bytes - this may of course vary depending on the HW available in the GPU).<u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt">As I see it, this wouldn't lead to THAT much overhead in the allocations, as local storage is per work-group, and the number of llocal arguments is, hopefully, not a very large number.<u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Whilst I'm all for saving memory when possible, I'm not sure adding a set of alignment values to the argument list of enqueue_kernel, for calls that have local arguments, and the extra complexity, even if it's
not large, is worth the saving of local memory allocations. I'd really like to understand why a single large alignment doesn't work in this case.<u></u><u></u></p>
</div>
<p class="MsoNormal">I'm completely aware that this may be my lack of understanding of something - hopefully I will learn something new, if that's the case...
<br>
<br>
--<u></u><u></u></p>
</div>
<p class="MsoNormal">Mats<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On 11 January 2018 at 12:02, Anastasia Stulova via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div id="m_-9076850807180646997m_4537029536541563720divtagdefaultwrapper">
<p style="margin:0in;margin-bottom:.0001pt"><span style="font-size:12.0pt;color:black">Hi Brian,<u></u><u></u></span></p>
<p style="margin:0in;margin-bottom:.0001pt"><span style="font-size:12.0pt;color:black"><u></u> <u></u></span></p>
<p style="margin:0in;margin-bottom:.0001pt"><span style="font-size:12.0pt;color:black">Considering the current implementation there is no reason we couldn't generate code with arbitrary pointer types instead of void. This is anyways implemented as a custom
check. I don't know though if there might be limitations if using different compilation toolchains or so. Although I can imagine this will require custom implementation anywhere. Should we clarify this in spec?<u></u><u></u></span></p>
<p style="margin:0in;margin-bottom:.0001pt"><span style="font-size:12.0pt;color:black"><u></u> <u></u></span></p>
<p style="margin:0in;margin-bottom:.0001pt"><span style="font-size:12.0pt;color:black">Cheers,<u></u><u></u></span></p>
<p style="margin:0in;margin-bottom:.0001pt"><span style="font-size:12.0pt;color:black">Anastasia<u></u><u></u></span></p>
</div>
<div class="MsoNormal" style="text-align:center" align="center">
<hr width="98%" size="2" align="center">
</div>
<div id="m_-9076850807180646997m_4537029536541563720divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Sumner, Brian <<a href="mailto:Brian.Sumner@amd.com" target="_blank">Brian.Sumner@amd.com</a>><br>
<b>Sent:</b> 10 January 2018 18:26:44<br>
<b>To:</b> Anastasia Stulova; Liu, Yaxun (Sam); cfe-dev (<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>); Bader, Alexey (<a href="mailto:alexey.bader@intel.com" target="_blank">alexey.bader@intel.com</a>)<br>
<b>Cc:</b> nd<u></u><u></u></span></p>
<div>
<div>
<p class="MsoNormal"><span style="color:black"><br>
<b>Subject:</b> RE: [RFC][OpenCL] Pass alignment of arguments in local addr space for device-side enqueued kernel to __enqueue_kernel functions<u></u><u></u></span></p>
</div>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
<div>
<div>
<div>
<div>
<p class="m_-9076850807180646997m4537029536541563720xmsonormal"><span style="color:#1f497d">From my perspective, this restriction is nonsense. OpenCL kernel local* arguments are not required to point to void. Why must block local* arguments point to void? They have to be cast
to actually be useful; this is an unnecessary extra step. And unless the actual type is available, the kernel enqueue mechanism has no choice to align the storage to 128 bytes since any local void * could actually be a local ulong16 *.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xmsonormal"><span style="color:#1f497d"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xmsonormal"><span style="color:#1f497d">Thanks,</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xmsonormal"><span style="color:#1f497d">Brian</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xmsonormal"><span style="color:#1f497d"> </span><u></u><u></u></p>
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="m_-9076850807180646997m4537029536541563720xmsonormal"><b><span style="font-size:10.0pt;font-family:"Tahoma",sans-serif">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma",sans-serif"> Anastasia Stulova [mailto:<a href="mailto:Anastasia.Stulova@arm.com" target="_blank">Anastasia.Stulova@arm.<wbr>com</a>]
<br>
<b>Sent:</b> Wednesday, January 10, 2018 9:55 AM<br>
<b>To:</b> Liu, Yaxun (Sam); cfe-dev (<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>); Bader, Alexey (<a href="mailto:alexey.bader@intel.com" target="_blank">alexey.bader@intel.com</a>)<br>
<b>Cc:</b> Sumner, Brian; nd<br>
<b>Subject:</b> Re: [RFC][OpenCL] Pass alignment of arguments in local addr space for device-side enqueued kernel to __enqueue_kernel functions</span><u></u><u></u></p>
</div>
</div>
<p class="m_-9076850807180646997m4537029536541563720xmsonormal"> <u></u><u></u></p>
<div id="m_-9076850807180646997m_4537029536541563720x_divtagdefaultwrapper">
<p><span style="color:black">Hi Sam,</span><u></u><u></u></p>
<p><span style="color:black"> </span><u></u><u></u></p>
<p><span style="color:black">There is a restriction in OpenCL spec I have referenced in my previous email - s6.13.17.2, which is implemented by Clang. If you look in the file test/SemaOpenCL/<a href="http://cl20-device-side-enqueue.cl" target="_blank">cl20-device-<wbr>side-enqueue.cl</a>
around line 117, you will see that block_B is rejected to be passed into enqueue_kernel because it has a parameter which isn't "local void*". If you think this is wrong perhaps it would make sense to revisit this bit and understand whether the current spec
should be changed to allow more optimal implementations to exist. But as for the current state, I don't think we can implement what you are suggesting because we can only have one block argument type for a block in enqueue.</span><u></u><u></u></p>
<p><span style="color:black"> </span><u></u><u></u></p>
<p><span style="color:black">Cheer,</span><u></u><u></u></p>
<p><span style="color:black">Anastasia</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xmsonormal" style="margin-bottom:12.0pt"><span style="color:black"> </span><u></u><u></u></p>
<div>
<div class="MsoNormal" style="text-align:center" align="center"><span style="color:black">
<hr width="98%" size="2" align="center">
</span></div>
<div id="m_-9076850807180646997m_4537029536541563720x_divRplyFwdMsg">
<p class="m_-9076850807180646997m4537029536541563720xmsonormal"><b><span style="color:black">From:</span></b><span style="color:black"> Liu, Yaxun (Sam) <<a href="mailto:Yaxun.Liu@amd.com" target="_blank">Yaxun.Liu@amd.com</a>><br>
<b>Sent:</b> 08 January 2018 22:25<br>
<b>To:</b> Anastasia Stulova; cfe-dev (<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>); Bader, Alexey (<a href="mailto:alexey.bader@intel.com" target="_blank">alexey.bader@intel.com</a>)<br>
<b>Cc:</b> Sumner, Brian; nd<br>
<b>Subject:</b> RE: [RFC][OpenCL] Pass alignment of arguments in local addr space for device-side enqueued kernel to __enqueue_kernel functions
</span><u></u><u></u></p>
<div>
<p class="m_-9076850807180646997m4537029536541563720xmsonormal"><span style="color:black"> </span><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal"><span style="color:black">My comments are below.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal"><b><span style="color:black">From:</span></b><span style="color:black"> Anastasia Stulova [<a href="mailto:Anastasia.Stulova@arm.com" target="_blank">mailto:Anastasia.Stulova@arm.<wbr>com</a>]
<br>
<b>Sent:</b> Tuesday, December 19, 2017 10:21 AM<br>
<b>To:</b> Liu, Yaxun (Sam) <<a href="mailto:Yaxun.Liu@amd.com" target="_blank">Yaxun.Liu@amd.com</a>>; cfe-dev (<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>) <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>>;
Bader, Alexey (<a href="mailto:alexey.bader@intel.com" target="_blank">alexey.bader@intel.com</a>) <<a href="mailto:alexey.bader@intel.com" target="_blank">alexey.bader@intel.com</a>><br>
<b>Cc:</b> Sumner, Brian <<a href="mailto:Brian.Sumner@amd.com" target="_blank">Brian.Sumner@amd.com</a>>; nd <<a href="mailto:nd@arm.com" target="_blank">nd@arm.com</a>><br>
<b>Subject:</b> Re: [RFC][OpenCL] Pass alignment of arguments in local addr space for device-side enqueued kernel to __enqueue_kernel functions</span><u></u><u></u></p>
</div>
</div>
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<div id="m_-9076850807180646997m_4537029536541563720x_x_divtagdefaultwrapper">
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black">> For example, if a block kernel has argument local int4*. Its alignment should be 16 bytes. </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal" style="margin-bottom:12.0pt"><span style="color:black">Perhaps I am missing something but I still don't see anything in the spec that requires pointers themselves to take alignment from the pointee type. In your example
int4* should be aligned to the pointer size (either 4 or 8 bites) while int4 should be 16 byte aligned. Clang will set the alignment of load and store operations correctly according to their data types specified in the source code (which is mainly inherited
from C implementation apart from some special data types like vectors). The arguments passed to kernels are allocated elsewhere and OpenCL compiler has no control over this.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal" style="margin-bottom:12.0pt"><span style="color:black"> Sam: The spec (v2.0s6.1.5) requires “the pointee is always appropriately aligned as required by the data type”, which means the pointee of the kernel argument
of int4* type should be aligned at 16 bytes.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal" style="margin-bottom:12.0pt"><span style="color:black"><br>
Regarding enqueued kernels as far as I understand you suggest to add block argument alignment info into builtin? Even though it shouldn't be strictly necessary I believe some implementation can indeed be done more efficiently using this. So I don't see any
problem adding this. However, spec (s6.13.17.2) mandates that the enqueued block function only has void* types as parameters: "Each argument must be declared to be a void pointer to local memory." So could you elaborate please where exactly do you plan to
get the optimal alignment from?</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal" style="margin-bottom:12.0pt"><span style="color:black"> Sam: The block function is passed to the builtin. The argument of the block function has the proper data type instead of void* type. Clang can deduce the alignment
of the pointee of the kernel argument from the block function type.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal" style="margin-bottom:12.0pt"><span style="color:black"><br>
Thanks,<br>
Anastasia</span><u></u><u></u></p>
<div>
<div class="MsoNormal" style="text-align:center" align="center"><span style="color:black">
<hr width="98%" size="2" align="center">
</span></div>
<div id="m_-9076850807180646997m_4537029536541563720x_x_divRplyFwdMsg">
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal"><b><span style="color:black">From:</span></b><span style="color:black"> Liu, Yaxun (Sam) <<a href="mailto:Yaxun.Liu@amd.com" target="_blank">Yaxun.Liu@amd.com</a>><br>
<b>Sent:</b> 15 December 2017 19:08<br>
<b>To:</b> Anastasia Stulova; cfe-dev (<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>); Bader, Alexey (<a href="mailto:alexey.bader@intel.com" target="_blank">alexey.bader@intel.com</a>)<br>
<b>Cc:</b> Sumner, Brian; nd<br>
<b>Subject:</b> RE: [RFC][OpenCL] Pass alignment of arguments in local addr space for device-side enqueued kernel to __enqueue_kernel functions
</span><u></u><u></u></p>
<div>
<p class="m_-9076850807180646997m4537029536541563720xxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black">Spec reference:</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black">OpenCL v2.0 s6.1.5</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black">The OpenCL compiler is responsible for aligning data items to the appropriate alignment as required by the data type. For arguments to a __kernel function declared to be a pointer to a data
type, the OpenCL compiler can assume that the pointee is always appropriately aligned as required by the data type. The behavior of an unaligned load or store is undefined, except for the vloadn, vload_halfn, vstoren, and vstore_halfn functions defined in
section 6.13.7.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black">s6.2.5</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black">Casting a pointer to a new type represents an unchecked assertion that the address is correctly aligned.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black">The C Standard, 6.3.2.3, paragraph 7 [ISO/IEC 9899:2011], states</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black">A pointer to an object or incomplete type may be converted to a pointer to a different object or incomplete type. If the resulting pointer is not correctly aligned for the referenced type,
the behavior is undefined.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black">For example, if a block kernel has argument local int4*. Its alignment should be 16 bytes. Passing a pointer aligned to 1 byte may result in undefined behavior. Most hardware can still load
from the unaligned memory but will a performance hit. If runtime wants to avoid the performance hit, it has to allocate the buffer at maximum possible alignment e.g. 32 bytes, which will result in wasted memory.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black">Sam</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><b><span style="color:black">From:</span></b><span style="color:black"> Anastasia Stulova [<a href="mailto:Anastasia.Stulova@arm.com" target="_blank">mailto:Anastasia.Stulova@arm.<wbr>com</a>]
<br>
<b>Sent:</b> Friday, December 15, 2017 10:40 AM<br>
<b>To:</b> Liu, Yaxun (Sam) <<a href="mailto:Yaxun.Liu@amd.com" target="_blank">Yaxun.Liu@amd.com</a>>; cfe-dev (<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>) <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>>;
Bader, Alexey (<a href="mailto:alexey.bader@intel.com" target="_blank">alexey.bader@intel.com</a>) <<a href="mailto:alexey.bader@intel.com" target="_blank">alexey.bader@intel.com</a>><br>
<b>Cc:</b> Sumner, Brian <<a href="mailto:Brian.Sumner@amd.com" target="_blank">Brian.Sumner@amd.com</a>>; nd <<a href="mailto:nd@arm.com" target="_blank">nd@arm.com</a>><br>
<b>Subject:</b> Re: [RFC][OpenCL] Pass alignment of arguments in local addr space for device-side enqueued kernel to __enqueue_kernel functions</span><u></u><u></u></p>
</div>
</div>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<div id="m_-9076850807180646997m_4537029536541563720x_x_x_divtagdefaultwrapper">
<p><span style="color:black"> </span><u></u><u></u></p>
<p><span style="color:black">><span class="m_-9076850807180646997m4537029536541563720xxxcurrenthithighlight"> OpenCL</span> spec requires that a pointer should be aligned to at least the pointee type.</span><u></u><u></u></p>
<p><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black">So a pointer to int16 would be 64 byte aligned? Seems strange though. Can you give me the spec reference?<br>
<br>
> Otherwise, __enqueue_kernel has to either allocate unaligned local buffer, which degrades performance, or allocates local buffer with extra alignment therefore wasted memory space.<br>
<br>
Can you explain in more details here, please.<br>
<br>
Cheer,<br>
Anastasia</span><u></u><u></u></p>
<div>
<div class="MsoNormal" style="text-align:center" align="center"><span style="color:black">
<hr width="98%" size="2" align="center">
</span></div>
<div id="m_-9076850807180646997m_4537029536541563720x_x_x_divRplyFwdMsg">
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><b><span style="color:black">From:</span></b><span style="color:black"> Liu, Yaxun (Sam) <<a href="mailto:Yaxun.Liu@amd.com" target="_blank">Yaxun.Liu@amd.com</a>><br>
<b>Sent:</b> 01 December 2017 19:45<br>
<b>To:</b> Anastasia Stulova; cfe-dev (<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>); Bader, Alexey (<a href="mailto:alexey.bader@intel.com" target="_blank">alexey.bader@intel.com</a>)<br>
<b>Cc:</b> Sumner, Brian<br>
<b>Subject:</b> [RFC][OpenCL] Pass alignment of arguments in local addr space for device-side enqueued kernel to __enqueue_kernel functions
</span><u></u><u></u></p>
<div>
<p class="m_-9076850807180646997m4537029536541563720xxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black">Hi,</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black">OpenCL spec requires that a pointer should be aligned to at least the pointee type. Therefore, if a device-side enqueued kernel has a local int* argument, it should be aligned to 4 bytes.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black">Since these buffers in local addr space are allocated by __enqueue_kernel, it needs to know the alignment of these buffers, not just their sizes.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black">Although such information is not passed to the original OpenCL builtin function enqueue_kernel, it can be obtained by checking the prototype of the block invoke function at compile time.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black">I would like to create a patch to pass this information to __enqueue_kernel. Otherwise, __enqueue_kernel has to either allocate unaligned local buffer, which degrades performance, or allocates
local buffer with extra alignment therefore wasted memory space.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black">Any comments?</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black">Thanks.</span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black"> </span><u></u><u></u></p>
<p class="m_-9076850807180646997m4537029536541563720xxxxmsonormal"><span style="color:black">Sam</span><u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
______________________________<wbr>_________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</blockquote></div><br></div></div>