<div dir="ltr">Forgot to mention:<br><br><div>> <span style="color:rgb(33,33,33)">Also, how would arcanist pick up two callsigns here? Wouldn't it just pick the from the closest surrounding .arcconfig?</span></div><div><span style="color:rgb(33,33,33)"><br></span></div><div><font color="#212121">The review request will belong to a single repository, as you noticed (from the closest .arcconfig to where the arc command was invoked).</font></div><div><font color="#212121"><br></font></div><div><font color="#212121">However, when commits land, they will be imported under either one (rL for LLVM diffs) or two (rL + rC for e.g. Clang diffs) repositories.</font></div><div><font color="#212121"><br></font></div><div><font color="#212121">Ben</font></div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Nov 27, 2017 at 10:00 AM Ben Hamilton <<a href="mailto:benhamilton@google.com">benhamilton@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Good point, and sorry for the confusion.<div><br></div><div><a href="https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo" target="_blank">Following the monorepo setup instructions</a>, diffs sent out from a monorepo will use <a href="https://reviews.llvm.org/diffusion/L/browse/llvm/trunk/.arcconfig" target="_blank">llvm/.arcconfig</a>.</div><div><br></div><div>I haven't committed any changes to that .arcconfig yet, and in addition there aren't yet any Herald rules which copy llvm-commits@ on review requests sent out to the LLVM project.</div><div><br></div><div>So, that explains why llvm-commits@ was not copied on D40312.</div><br class="m_-3619433691557704808inbox-inbox-Apple-interchange-newline"><div>The previous setup made sense, since review requests for clang et al were also lumped together in the <a href="https://reviews.llvm.org/diffusion/L/" target="_blank">rL LLVM Diffusion repository</a>, and we didn't want to subscribe llvm-commits@ on those.<br></div><div><br></div><div>Once I land the set of commits so each project has its own Diffusion repository (and we give it a week or so so everyone is up to date), we can update llvm/.arcconfig to explicitly set revisions as belonging to the rL repository, and then set up a Herald rule to subscribe llvm-commits@ on those.</div><div><br></div><div>Does that help?</div></div><div dir="ltr"><div><br></div><div>Ben</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Nov 27, 2017 at 9:42 AM Philip Pfaffe <<a href="mailto:philip.pfaffe@gmail.com" target="_blank">philip.pfaffe@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Ben,</div>(+llvm-dev since the email I'm replying to wasn't sent there)</div><div dir="ltr"><div><br></div><div>2017-11-21 17:18 GMT+01:00 Ben Hamilton via cfe-dev <span dir="ltr"><<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span>:<br></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">OK. I confirmed that Stephan's process to send out cross-repo diffs from the monorepo is not affected by my proposal.<div><br></div></div></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>I'm a bit late to the party, and I might just not have comprehended this correctly. But does your example actually work? I didn't see any email about D40312 on llvm-commits, shouldn't there have been one? Also, how would arcanist pick up two callsigns here? Wouldn't it just pick the from the closest surrounding .arcconfig?</div><div> </div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div>tl;dr: <a href="https://reviews.llvm.org/D40312" target="_blank">https://reviews.llvm.org/D40312</a> (which was sent out on top of D40179 to emulate what happens with a monorepo after my proposal lands).</div><div><br></div><div>Steps I took (starting with <a href="https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo" style="outline:transparent solid 1px" target="_blank">https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo</a>):<div><br></div><div>===</div>% git clone <a href="https://github.com/llvm-project/llvm-project-20170507/" target="_blank">https://github.com/llvm-project/llvm-project-20170507/</a> llvm-project<div>% cd llvm-project</div><div>% cp llvm/.arcconfig .</div><div>% mkdir -p .git/info</div><div>% echo .arcconfig >> .git/info/exclude</div><div># Manually apply D40179 into the clang-tools-extra directory</div><div><div>% arc export --revision D40179 --git | patch -d clang-tools-extra -p1</div><div>patching file .arcconfig</div></div><div><div>% git diff</div><div>diff --git a/clang-tools-extra/.arcconfig b/clang-tools-extra/.arcconfig</div><div>index f846581763e..d4a00161bce 100644</div><div>--- a/clang-tools-extra/.arcconfig</div><div>+++ b/clang-tools-extra/.arcconfig</div><div>@@ -1,4 +1,4 @@</div><div> {</div><div>- "project_id" : "clang-tools-extra",</div><div>+ "repository.callsign" : "CTE",</div><div> "conduit_uri" : "<a href="https://reviews.llvm.org/" target="_blank">https://reviews.llvm.org/</a>"</div><div> }</div></div><div><div> % git commit -a -m "Differential Revision: <a href="https://reviews.llvm.org/D40179" target="_blank">https://reviews.llvm.org/D40179</a>"</div></div><div><div> % echo "Test 1" >> llvm/README.txt </div></div><div><div> % echo "Test 2" >> clang-tools-extra/README.txt </div></div><div><div> % git commit -a -m "[Test] Monorepo test diff crossing Differential repositories" </div></div><div><div> % arc diff --create --reviewers sberg HEAD^</div></div><div>===</div><span class="m_-3619433691557704808m_6474957656503749231gmail-m_-1916741355599721805HOEnZb"><font color="#888888"><div><br></div><div><div>Ben</div></div></font></span></div></div><div class="m_-3619433691557704808m_6474957656503749231gmail-m_-1916741355599721805HOEnZb"><div class="m_-3619433691557704808m_6474957656503749231gmail-m_-1916741355599721805h5"><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 21, 2017 at 8:00 AM Stephan Bergmann <<a href="mailto:sbergman@redhat.com" target="_blank">sbergman@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 11/21/2017 03:41 PM, Ben Hamilton wrote:<br>
> > My understanding was that, while there currently is no official<br>
> monorepo, it is at least possible and accepted to send single,<br>
> cross-repo patches for review. That would no longer be possible, right?<br>
><br>
> I assume cross-repo patches would be constructed by hand, right? Or do<br>
> you mean using the unofficial monorepo from 2016<br>
> <<a href="https://github.com/joker-eph/llvm-project" rel="noreferrer" target="_blank">https://github.com/joker-eph/llvm-project</a>>?<br>
<br>
I'm using <<a href="https://github.com/llvm-project/llvm-project-20170507" rel="noreferrer" target="_blank">https://github.com/llvm-project/llvm-project-20170507</a>> (as<br>
advertised at<br>
<<a href="https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo" rel="noreferrer" target="_blank">https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo</a>>),<br>
where such a "cross-repo diff" is just a matter of a plain 'git diff'.<br>
<br>
> An example of an existing cross-repo review in Differential would be<br>
> nice—do you happen to have one handy?<br>
<br>
I just happened to file <<a href="https://reviews.llvm.org/D40295" rel="noreferrer" target="_blank">https://reviews.llvm.org/D40295</a>> a moment ago,<br>
spanning clang and compiler-rt.<br>
<br>
> I think either way, we'd keep the ability to send cross-repo patches to<br>
> the top-level LLVM repo just the same way you could today.<br>
><br>
> I'll confirm that if you can help me construct an example cross-repo<br>
> patch for review.<br>
<br>
Thanks,<br>
Stephan<br>
</blockquote></div>
</div></div><br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div></div></div></blockquote></div></blockquote></div>