<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Thank you James, I could update the original (D5767) review.</p>
<p>Regards,<br>
Ábel<br>
</p>
<br>
<div class="moz-cite-prefix">Am 2017-10-17 um 19:19 schrieb James Y
Knight:<br>
</div>
<blockquote type="cite"
cite="mid:CAA2zVHpSKgNcs7Jg-nP0xzhSNMWnsKQ9D8X81yLs=oDpY-PE3g@mail.gmail.com">
<div dir="ltr">You need to "commandeer" a revision before you can
add diff to it. (That option is in the action menu above the
main comment box when viewing it).</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Oct 16, 2017 at 4:04 PM, Abel
Sinkovics via cfe-dev <span dir="ltr"><<a
href="mailto:cfe-dev@lists.llvm.org" target="_blank"
moz-do-not-send="true">cfe-dev@lists.llvm.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>Hi Manuel,</p>
<p>I've tried to do so, but the UI doesn't let me do that.
I can choose between creating a new revision and
updating the one I recently created (D38818). I assume
this is because D5767 was created by Mikael (cc'd), not
me.</p>
<p>Regards,<br>
Ábel<br>
</p>
<div>
<div class="h5"> <br>
<div class="m_-7925623196684673063moz-cite-prefix">Am
2017-10-16 um 00:06 schrieb Manuel Klimek:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hey Abel, is there any chance you can
add the patches to <a
href="https://reviews.llvm.org/D5767"
target="_blank" moz-do-not-send="true">https://reviews.llvm.org/<wbr>D5767</a> instead
of starting a new review? Given the context on the
other patch is rather extensive, that would help
review :)<br>
<br>
<div class="gmail_quote">
<div dir="ltr">On Wed, Oct 11, 2017 at 4:05 PM
Manuel Klimek <<a
href="mailto:klimek@google.com"
target="_blank" moz-do-not-send="true">klimek@google.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0
0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div dir="ltr">Hi, thanks for letting me know,
excited to see this make progress \o/
<div><br>
</div>
<div>Generally, if you follow the guidelines
here: <a
href="https://llvm.org/docs/Phabricator.html"
target="_blank" moz-do-not-send="true">https://llvm.org/docs/<wbr>Phabricator.html</a></div>
<div>you'll get a code review that is cc'ed
to the cfe-commits list (you can also put
me in as reviewer), which is generally how
people find patches.</div>
<div><br>
</div>
<div>You can also continue the old review by
manually specifying it when uploading the
patch via arc or in the UI.</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Wed, Oct 11, 2017 at 1:16
PM Abel Sinkovics <<a
href="mailto:abel@sinkovics.hu"
target="_blank" moz-do-not-send="true">abel@sinkovics.hu</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">Hi Manuel,<br>
<br>
Kristóf (cc'd) has implemented the missing
tests for the Templight pull<br>
request for Clang. I have updated the
patch, but the system seems to<br>
have created another pull request as the
result of this. You can find it<br>
here: <a
href="https://reviews.llvm.org/D38818"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://reviews.llvm.org/<wbr>D38818</a><br>
<br>
Please let us know if there are further
things we should address.<br>
<br>
Thanks,<br>
Ábel<br>
<br>
<br>
</blockquote>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
</div>
</div>
</div>
<br>
______________________________<wbr>_________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org"
moz-do-not-send="true">cfe-dev@lists.llvm.org</a><br>
<a
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>