<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 10/4/2017 3:47 AM, ORiordan, Martin
via cfe-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:6E24DDEE941CC74AAF53D4AC6D6EAEB5328DB297@IRSMSX103.ger.corp.intel.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Book Antiqua";
panose-1:2 4 6 2 5 3 5 3 3 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Book Antiqua",serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Book
Antiqua",serif">Hi CFE-Devs,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Book
Antiqua",serif"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Book
Antiqua",serif">When I compile the following tiny test
with </span><span
style="font-size:12.0pt;font-family:"Courier New"">-std=c89</span><span
style="font-size:12.0pt;font-family:"Book
Antiqua",serif"> (</span><span
style="font-size:12.0pt;font-family:"Courier New"">clang
std=c89 c xxx.c</span><span
style="font-size:12.0pt;font-family:"Book
Antiqua",serif">):<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span
style="font-size:12.0pt;font-family:"Courier New"">foo(x)
{<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span
style="font-size:12.0pt;font-family:"Courier New"">
return;<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span
style="font-size:12.0pt;font-family:"Courier New"">}<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Book
Antiqua",serif">I get the following error message:<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span
style="font-size:12.0pt;font-family:"Courier New"">xxx.c:2:3:
error: non-void function 'foo' should return a value
[-Wreturn-type]<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span
style="font-size:12.0pt;font-family:"Courier New"">
return;<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span
style="font-size:12.0pt;font-family:"Courier New"">
^<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span
style="font-size:12.0pt;font-family:"Courier New"">1
error generated.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Book
Antiqua",serif"><o:p> </o:p></span></p>
</div>
</blockquote>
<br>
Looks like an oversight in <a class="moz-txt-link-freetext" href="https://reviews.llvm.org/rL108108">https://reviews.llvm.org/rL108108</a>; in
C99, we want to default to an error, but C89 we shouldn't, as you've
pointed out. See also <a class="moz-txt-link-freetext" href="https://bugs.llvm.org//show_bug.cgi?id=12216">https://bugs.llvm.org//show_bug.cgi?id=12216</a>.<br>
<br>
That said, it's been like this for seven years... it seems like this
isn't causing issues in practice.<br>
<br>
-Eli<br>
<pre class="moz-signature" cols="72">--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project</pre>
</body>
</html>