<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Book Antiqua";
panose-1:2 4 6 2 5 3 5 3 3 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"Book Antiqua \,serif";
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;
mso-fareast-language:EN-US;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Book Antiqua",serif;
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Book Antiqua",serif;
color:#943634;
font-weight:normal;
font-style:normal;
text-decoration:none none;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-IE link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Book Antiqua",serif;color:#943634'>Hi Eli,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Book Antiqua",serif;color:#943634'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Book Antiqua",serif;color:#943634'>The “wrapper” is called ‘</span><span style='font-size:12.0pt;font-family:"Courier New"'>libcxx/include/stdio.h</span><span style='font-size:12.0pt;font-family:"Book Antiqua",serif;color:#943634'>’, but I think that I have managed to get an SVN merge problem that is not properly resolved (though how far back I cannot tell) as I can clearly see that the new wrapper version of ‘</span><span style='font-size:12.0pt;font-family:"Courier New"'><stdio.h></span><span style='font-size:12.0pt;font-family:"Book Antiqua",serif;color:#943634'>’ is a lot simpler than the one I have so this is a false negative. My apologies.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Book Antiqua",serif;color:#943634'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Book Antiqua",serif;color:#943634'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Book Antiqua",serif;color:#943634'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Book Antiqua",serif;color:#943634'> MartinO<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Book Antiqua",serif;color:#943634'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='color:windowtext;mso-fareast-language:EN-IE'>From:</span></b><span lang=EN-US style='color:windowtext;mso-fareast-language:EN-IE'> cfe-dev [mailto:cfe-dev-bounces@lists.llvm.org] <b>On Behalf Of </b>Friedman, Eli via cfe-dev<br><b>Sent:</b> 21 September 2017 19:36<br><b>To:</b> ORiordan, Martin <martin.oriordan@intel.com>; Clang Dev <cfe-dev@lists.llvm.org><br><b>Subject:</b> Re: [cfe-dev] [LibC++] Incompatibility between '<stdio.h> from LibC++ v5.0's ' Newlib v2.5.0, and a workaround/fix<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>On 9/21/2017 8:07 AM, ORiordan, Martin via cfe-dev wrote:<span style='font-size:12.0pt;mso-fareast-language:EN-IE'><o:p></o:p></span></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Book Antiqua ,serif",serif'>I have been working on stabilising our out-of-tree sources following the upgrade to the v5.0 Final Release, and came across an incompatibility between the ‘</span><span style='font-size:12.0pt;font-family:"Courier New"'><stdio.h></span><span style='font-size:12.0pt;font-family:"Book Antiqua ,serif",serif'>’ provided with Newlib v2.5.0 and the one provided with LibC++ v5.0.</span><o:p></o:p></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Book Antiqua ,serif",serif'> </span><o:p></o:p></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Book Antiqua ,serif",serif'>The problem is how LibC++ handles the ‘</span><span style='font-size:12.0pt;font-family:"Courier New"'>getc</span><span style='font-size:12.0pt;font-family:"Book Antiqua ,serif",serif'>’ and ‘</span><span style='font-size:12.0pt;font-family:"Courier New"'>putc</span><span style='font-size:12.0pt;font-family:"Book Antiqua ,serif",serif'>’ implementations, and if these are defined it uses a shim, then ‘</span><span style='font-size:12.0pt;font-family:"Courier New"'>#undef</span><span style='font-size:12.0pt;font-family:"Book Antiqua ,serif",serif'>’s the original, and redefines them as functions.</span><o:p></o:p></p></blockquote><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman",serif;mso-fareast-language:EN-IE'><br>Please specify which file, on which branch, you're talking about. As far as I can tell, libc++ hasn't included a wrapper for putc since r249475 (roughly two years ago).<br><br>-Eli <o:p></o:p></span></p><pre>-- <o:p></o:p></pre><pre>Employee of Qualcomm Innovation Center, Inc.<o:p></o:p></pre><pre>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project<o:p></o:p></pre></div></body></html>