<div dir="ltr">+1 to the idea of using phab, as it makes reviewing patches (especially small ones) much less work to reviewers.<div>(I also now hunted down and reviewed the patch, sorry for the long review time)</div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 14, 2017 at 10:23 PM Chad Rosier via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>Hi Erik,</p>
<p>Submitting patches to the maining list is perfectly fine, but if
you haven't already done so you might consider submitting your
patch via Phabricator (see: <a class="m_-6069292804221413691moz-txt-link-freetext" href="https://reviews.llvm.org" target="_blank">https://reviews.llvm.org</a>)? I find
that approach generally garners more attention. You can use git
blame to see who frequently contributes to clang-format and add
them to the patch as a reviewer. Here's a link for using
Phabricator: <a class="m_-6069292804221413691moz-txt-link-freetext" href="http://llvm.org/docs/Phabricator.html" target="_blank">http://llvm.org/docs/Phabricator.html</a><br>
</p>
The general rule of thumb is to ping a patch about once a week, if
you haven't received any feedback.<br>
<br>
HTH,<br>
Chad</div><div text="#000000" bgcolor="#FFFFFF"><br>
<br>
<div class="m_-6069292804221413691moz-cite-prefix">On 7/14/2017 4:13 PM, Erik Uhlmann via
cfe-dev wrote:<br>
</div>
<blockquote type="cite">
<pre>Hi,
I’m Erik Uhlmann, an intern at VMware and new to Clang/LLVM. Last week I created a small patch for a minor bug in clang-format (bug tracker: <a class="m_-6069292804221413691moz-txt-link-freetext" href="https://bugs.llvm.org/show_bug.cgi?id=33665" target="_blank">https://bugs.llvm.org/show_bug.cgi?id=33665</a>) and submitted to the commit mailing list (as per the LLVM developer policy). I haven’t heard anything back since then. What should I be doing to get my patch accepted? (I’ve attached a new patch against the current svn trunk here.)
Thanks,
Erik Uhlmann
</pre>
<br>
<fieldset class="m_-6069292804221413691mimeAttachmentHeader"></fieldset>
<br>
<pre>_______________________________________________
cfe-dev mailing list
<a class="m_-6069292804221413691moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>
<a class="m_-6069292804221413691moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
<br>
</div>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div>