<div dir="ltr">General comments:<div>* Are these necessary for parsing system headers?</div><div>* Is it possible to emit some -Wmicrosoft warning for when we do these? (<a href="https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJHP7nXRua_0URXxxJ3oYRq0/edit#slide=id.g71ecd450e_2_812">https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJHP7nXRua_0URXxxJ3oYRq0/edit#slide=id.g71ecd450e_2_812</a>)</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 13, 2017 at 5:21 PM, Keane, Erich via cfe-dev <span dir="ltr"><<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all, I've prepared a number of fixes to the preprocessor in the name of MSVC compatibility!<br>
<br>
<a href="https://reviews.llvm.org/D32046" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D32046</a><br>
<a href="https://reviews.llvm.org/D32049" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D32049</a><br>
<a href="https://reviews.llvm.org/D32050" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D32050</a><br>
<a href="https://reviews.llvm.org/D32051" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D32051</a><br>
<a href="https://reviews.llvm.org/D32052" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D32052</a><br>
<br>
Since Richard Smith is the only one who has any chance of being the code owner here, and because Reid is our MSVC compatibility Czar, I added them to the review.  However, if anyone knows of anyone with sufficient knowledge of the preprocessor, I'd appreciate it if you could add them to the review as well!<br>
<br>
Thanks all,<br>
Erich<br>
______________________________<wbr>_________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a><br>
</blockquote></div><br></div>