<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">The context is that I’m working on the plan here: <a href="http://lists.llvm.org/pipermail/cfe-dev/2016-July/049985.html" class="">http://lists.llvm.org/pipermail/cfe-dev/2016-July/049985.html</a><div class=""><br class=""></div><div class="">Trying to remove “all" of the “always_inline”, making the public APIs hidden, and the internal APIs “internal_linkage”.</div><div class=""><br class=""></div><div class="">The kind of discrepancy I mentioned below puzzles me though.</div><div class=""><br class=""></div><div class="">— </div><div class="">Mehdi</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 31, 2017, at 11:49 PM, Eric Fiselier <<a href="mailto:eric@efcs.ca" class="">eric@efcs.ca</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Honestly I've been wondering about the same things.<div class=""><br class=""></div><div class="">Libc++ needs to re-evaluate it's entire approach to symbol visibility especially w.r.t ABI management.</div><div class="">I think a lot of the existing behavior is purely historical, and newer parts of the library just try to mimic that</div><div class="">regardless of QoI. In particular I'm sceptical that libc++'s use of __always_inline__ helps prevent "ABI problems".</div><div class=""><br class=""></div><div class="">I would love to start a discussion on this, especially if it leads to concrete example</div><div class="">that can be turned into test cases</div><div class=""><br class=""></div><div class="">/Eric</div><div class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Mar 31, 2017 at 11:57 PM, Mehdi Amini via cfe-dev <span dir="ltr" class=""><<a href="mailto:cfe-dev@lists.llvm.org" target="_blank" class="">cfe-dev@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Similarly with the public free template functions:<br class="">
<br class="">
<br class="">
template <class _L0, class _L1><br class="">
void<br class="">
lock(_L0& __l0, _L1& __l1)<br class="">
<br class="">
and<br class="">
<br class="">
template <class _L0, class _L1, class _L2, class ..._L3><br class="">
inline _LIBCPP_INLINE_VISIBILITY<br class="">
void<br class="">
lock(_L0& __l0, _L1& __l1, _L2& __l2, _L3& …__l3)<br class="">
<br class="">
<br class="">
—<br class="">
Mehdi<br class="">
<div class=""><div class="h5"><br class="">
<br class="">
<br class="">
> On Mar 31, 2017, at 10:46 PM, Mehdi Amini via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> Hi,<br class="">
><br class="">
> I’m wondering about libc++ visibility for the internals of the library. For example why do we define:<br class="">
><br class="">
> _LIBCPP_INLINE_VISIBILITY<br class="">
> void __construct_at_end(size_type __n, const_reference __x);<br class="">
><br class="">
> with inline/hidden visibility, but not this one:<br class="">
><br class="">
> template <class _ForwardIterator><br class="">
> typename enable_if <__is_forward_iterator<_<wbr class="">ForwardIterator>::value, void>::type<br class="">
> __construct_at_end(_<wbr class="">ForwardIterator __first, _ForwardIterator __last, size_type __n);<br class="">
><br class="">
><br class="">
> Thanks,<br class="">
><br class="">
> —<br class="">
> Mehdi<br class="">
><br class="">
</div></div>> ______________________________<wbr class="">_________________<br class="">
> cfe-dev mailing list<br class="">
> <a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-dev</a><br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
cfe-dev mailing list<br class="">
<a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-dev</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>