<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
p.p1, li.p1, div.p1
{mso-style-name:p1;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.s1
{mso-style-name:s1;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.s2
{mso-style-name:s2;}
span.s3
{mso-style-name:s3;}
p.p2, li.p2, div.p2
{mso-style-name:p2;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.s4
{mso-style-name:s4;}
span.s5
{mso-style-name:s5;}
span.colour
{mso-style-name:colour;}
span.font
{mso-style-name:font;}
span.size
{mso-style-name:size;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle30
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">That's very odd, because other options that are defined in similar ways (e.g. –fparse-all-comments) do not get forwarded to the linker. Comparing how your
option behaves relative to other similar options might help diagnose the problem.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Peeter Joot [mailto:peeterjoot@protonmail.com]
<br>
<b>Sent:</b> Thursday, March 16, 2017 5:04 AM<br>
<b>To:</b> Mehdi Amini<br>
<b>Cc:</b> Robinson, Paul; cfe-dev@lists.llvm.org<br>
<b>Subject:</b> Re: [cfe-dev] how to avoid passing new clang front end option to the linker?<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="p1">The debugger shows that this forwardToGcc path does get hit. Setting a breakpoint just before it, I find my option:<o:p></o:p></p>
<p class="p1"><span class="s1">6681</span><span class="apple-converted-space">
</span><span class="s1">for (const auto &A : Args) {</span><o:p></o:p></p>
<p class="p1"><span class="s1">6682</span><span class="apple-converted-space">
</span><span class="s1">if (A->getOption().matches(options::OPT_fmyopt_EQ)) {</span><span class="apple-converted-space"> </span><o:p></o:p></p>
<p class="p1"><span class="s1">6683 </span><span class="apple-converted-space">
</span><span class="s1">printf("here\n");</span><o:p></o:p></p>
<p class="p1"><span class="s1">6684</span><span class="apple-converted-space">
</span><span class="s1">}</span><o:p></o:p></p>
<p class="p1"><span class="s1">6685</span><span class="apple-converted-space">
</span><span class="s1">if (forwardToGCC(A->getOption())) {</span><o:p></o:p></p>
<p class="p1"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><span class="s1">$3 = {</span><o:p></o:p></p>
</div>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">Opt = {</span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">Info = 0x7ffff43f00d0 <InfoTable+28336>,</span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">Owner = 0x45c170</span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">},</span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">BaseArg = 0x0,</span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">Spelling = {</span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">static npos = 18446744073709551615,</span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">Data = 0x7fffffffdd1e "-fmyopt=extended",</span><span class="apple-converted-space"> </span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">Length = 10</span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">},</span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">...</span><o:p></o:p></p>
<p class="p1"><span class="s1">}</span><o:p></o:p></p>
<p class="p1"><o:p> </o:p></p>
<div>
<p class="MsoNormal">then in the forward code:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="p1"><span class="s1">/home/pjoot/<a href="http://llvm.pragmas/tools/clang/lib/Driver/Tools.cpp:295">llvm.pragmas/tools/clang/lib/Driver/Tools.cpp:295</a></span><o:p></o:p></p>
<p class="p1"><span class="s1">295</span><span class="apple-converted-space">
</span><span class="s1">auto pk = O.getKind() != Option::InputClass ;</span><o:p></o:p></p>
<p class="p1"><span class="s1">296</span><span class="apple-converted-space">
</span><span class="s1">auto pd = O.hasFlag(options::DriverOption) ;</span><o:p></o:p></p>
<p class="p1"><span class="s1">297</span><span class="apple-converted-space">
</span><span class="s1">auto pl = O.hasFlag(options::LinkerInput);</span><o:p></o:p></p>
<p class="p1"><span class="s1">298</span><span class="apple-converted-space">
</span><span class="s1">return pk && !pd && !pl;</span><o:p></o:p></p>
<p class="p1"><span class="s1">$4 = true</span><o:p></o:p></p>
<p class="p1"><span class="s1">$5 = false</span><o:p></o:p></p>
<p class="p1"><span class="s1">$6 = false</span><o:p></o:p></p>
<div>
<p class="MsoNormal"><span class="s1">DriverOption and LinkerInput are both false so the result is true:</span><o:p></o:p></p>
</div>
<p class="p1"><span class="s1">$7 = true</span><o:p></o:p></p>
<div>
<div>
<div>
<p class="MsoNormal">I then see my flag get inserted into the CmdArgs for the gcc command line (although I can't confirm easily in the debugger, since the SmallString class is garbage to gdb).<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Perhaps I should be setting DriverOption in Options.td along with CC1Option?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">--<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Peeter<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">-------- Original Message --------<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Subject: Re: [cfe-dev] how to avoid passing new clang front end option to the linker?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Local Time: March 15, 2017 7:19 PM<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">UTC Time: March 15, 2017 11:19 PM<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">From: <a href="mailto:mehdi.amini@apple.com">mehdi.amini@apple.com</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">To: Peeter Joot <<a href="mailto:peeterjoot@protonmail.com">peeterjoot@protonmail.com</a>><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">"Robinson, Paul" <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>>,
<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a> <<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On Mar 15, 2017, at 12:11 PM, Peeter Joot via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal">I think that I've probably declared my option inappropriately. It was:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">// Options.td<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span class="s1">def fmyopt_EQ : Joined<["-"], "fmyopt=">, Group<f_clang>, Flags<[CC1Option]>,</span><o:p></o:p></p>
</div>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">HelpText<"...">;</span><o:p></o:p></p>
<div>
<p class="MsoNormal">I think that the choice of whether or not to propagate it to the linker comes from here:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="p1"><span class="s1">static</span><span class="s2"> </span><span class="s1">bool</span><span class="s2">
</span><span class="s3">forwardToGCC</span><span class="s2">(</span><span class="s1">const</span><span class="s2"> Option &O) {</span><o:p></o:p></p>
<p class="p2"><span class="apple-converted-space"> </span><span class="s2">// Don't forward inputs from the original command line.</span><span class="apple-converted-space">
</span><span class="s2">They are added from</span><o:p></o:p></p>
<p class="p2"><span class="apple-converted-space"> </span><span class="s2">// InputInfoList.</span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s5">return</span><span class="s2"> O.</span><span class="s3">getKind</span><span class="s2">() != Option::InputClass &&</span><o:p></o:p></p>
<p class="p1"><span class="apple-converted-space"> </span><span class="s2">!O.</span><span class="s3">hasFlag</span><span class="s2">(options::DriverOption) && !O.</span><span class="s3">hasFlag</span><span class="s2">(options::LinkerInput);</span><o:p></o:p></p>
<p class="p1"><span class="s2">}</span><o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><span class="s2">i.e. the LinkerInput flag. Perhaps this is implied by CC1Option in my Options.td line?</span><o:p></o:p></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I’m not sure, there is a ! in front the the LinkerInput test, so it’ll return true if it is *not* a LinkerInput.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal"><span class="s2">I tried changing to</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><span class="s1">def fmyopt_EQ : Joined<["-"], "fmyopt=">, Group<f_clang>, Flags<[DriverOption]>,</span><o:p></o:p></p>
</div>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">HelpText<"...”>;</span><o:p></o:p></p>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Maybe:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal"><span class="s1">def fmyopt_EQ : Joined<["-"], "fmyopt=">, Group<f_clang>, Flags<[DriverOption, CC1Option]>,</span><o:p></o:p></p>
</div>
</blockquote>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><span class="s1">?</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><span class="s1">— </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span class="s1">Mehdi</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal">but now my option is no longer recognized in the compilation phase.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Hmm, wondering if I should have put this in CC1Options.td instead, which I just spotted?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal">--<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Peeter<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">-------- Original Message --------<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Subject: RE: [cfe-dev] how to avoid passing new clang front end option to the linker?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Local Time: March 15, 2017 2:25 PM<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">UTC Time: March 15, 2017 6:25 PM<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">From: <a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">To: Peeter Joot <<a href="mailto:peeterjoot@protonmail.com">peeterjoot@protonmail.com</a>><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a> <<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span class="size"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">The linker command line would be constructed in the driver (clang/lib/Driver/…)
and exactly where the code is depends on your triple. You could grep for 'Linker::ConstructJob' and see what looks most likely, or try stepping through the driver in a debugger to see which one is invoked. I am a little surprised that arbitrary –f options
would be passed through in the link phase.</span></span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span class="size"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">HTH,</span></span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span class="size"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr</span></span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span class="size"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span></span><o:p></o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span class="size"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b></span><span class="size"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">
cfe-dev [<a href="mailto:cfe-dev-bounces@lists.llvm.org">mailto:cfe-dev-bounces@lists.llvm.org</a>]
<b>On Behalf Of </b>Peeter Joot via cfe-dev</span></span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""><br>
<span class="size"><b>Sent:</b> Wednesday, March 15, 2017 8:10 AM</span><br>
<span class="size"><b>To:</b> <a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a></span><br>
<span class="size"><b>Subject:</b> [cfe-dev] how to avoid passing new clang front end option to the linker?</span></span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">I'm attempting to implement a new clang front end option for my project (<span class="s1">-fmyopt=blah)</span>, and have made the changes required that I can access and act on it
in my Target class when compiling. When linking, it causes a bit of trouble, as clang passes it on to gcc in the link phase:<o:p></o:p></p>
</div>
<p class="p1"><span class="apple-converted-space"> </span><span class="s1">"/usr/lib64/ccache/gcc" -g -D QSIZE -fpic -MD -fmyopt=blah -v -m64 -o tryit /run/user/1002/tryit-46641b.o</span><o:p></o:p></p>
<p class="p1">which gcc objects to. <o:p></o:p></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">What part of the code is the link command line constructed in, and what is the mechanism used to select which options get passed to other stages (or an example of that)?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">--<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Peeter<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">_______________________________________________<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">cfe-dev mailing list<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><o:p></o:p></p>
</div>
</div>
</blockquote>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</body>
</html>