<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 14.03.2017 00:33, Reid Kleckner via
cfe-dev wrote:<br>
</div>
<blockquote
cite="mid:CACs=tyJmuNBf80nBSTcGuyvJ_UsRpHcfVDXuq475OSwju8LaJg@mail.gmail.com"
type="cite">
<div dir="ltr">I think this is something the compiler should
catch. I'm writing a generalized warning in clang for it right
now.</div>
</blockquote>
Yes, I agree. In fact, this is how I got here myself. I ran test <br>
<pre class="diffs">${LLVM_SRC}/llvm/tools/clang/test/Lexer/cxx1z-trigraphs.cpp</pre>
using Clank (the Java port of CLang)<br>
<a class="moz-txt-link-freetext" href="https://eurollvm2017.sched.com/event/9wDw/clank-java-port-of-cc-compiler-frontend">https://eurollvm2017.sched.com/event/9wDw/clank-java-port-of-cc-compiler-frontend</a><br>
and got Java-assert that reducing from enumerator to 5 bits doesn't
fit for TST_error value :-)<br>
<br>
Please, send me the changeset when you are done with compiler
warning.<br>
<br>
Thanks!<br>
Vladimir.<br>
<br>
<blockquote
cite="mid:CACs=tyJmuNBf80nBSTcGuyvJ_UsRpHcfVDXuq475OSwju8LaJg@mail.gmail.com"
type="cite">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Mar 13, 2017 at 12:57 PM,
Vladimir Voskresensky via cfe-dev <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:cfe-dev@lists.llvm.org" target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> Reid,<br>
<br>
May be it's worth to have the same assert for
clang::DeclSpec::TypeSpecType?<br>
<br>
Thanks,<br>
Vladimir.
<div>
<div class="h5"><br>
<br>
<div class="m_-153245685904042596moz-cite-prefix">On
13.03.2017 21:59, Reid Kleckner via cfe-dev wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Thanks, fixed in r297654.</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Mar 13, 2017 at
10:35 AM, Vladimir Voskresensky via cfe-dev <span
dir="ltr"><<a moz-do-not-send="true"
class="m_-153245685904042596moz-txt-link-abbreviated"
href="mailto:cfe-dev@lists.llvm.org"
target="_blank">cfe-dev@lists.llvm.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0
0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">Hello Clang
Developers,<br>
<br>
in file clang/Basic/Specifiers.h there is<br>
struct clang::WrittenBuiltinSpecs {<br>
/*DeclSpec::TST*/ unsigned Type : 5; //
<< must be *6*<br>
....<br>
};<br>
<br>
"Type" field must be 6 to match DeclSpec::TST
which is the same as enum TypeSpecifierType<br>
which has<br>
TST_error // erroneous type<br>
with value 43 which can not be kept in 5 bits
field.<br>
<br>
as a correct example you can see that<br>
clang::DeclSpec::TypeSpecType field is 6 bits<br>
<br>
So, we corrupt values during save in
clang::DeclSpec::SaveWrittenBu<wbr>iltinSpecs
for all after TST_image1d_t.<br>
Btw, due to this TST_error is changed to
TST_float128....<br>
<br>
Hope it helps,<br>
Vladimir.<br>
______________________________<wbr>_________________<br>
cfe-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:cfe-dev@lists.llvm.org"
target="_blank">cfe-dev@lists.llvm.org</a><br>
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev"
rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a><br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset
class="m_-153245685904042596mimeAttachmentHeader"></fieldset>
<br>
<pre>______________________________<wbr>_________________
cfe-dev mailing list
<a moz-do-not-send="true" class="m_-153245685904042596moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>
<a moz-do-not-send="true" class="m_-153245685904042596moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
</div></div></div>
______________________________<wbr>_________________
cfe-dev mailing list
<a moz-do-not-send="true" href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>
<a moz-do-not-send="true" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a>
</blockquote></div>
</div>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre wrap="">_______________________________________________
cfe-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
</body></html>