<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Thank you!<br>
<br>
<div class="moz-cite-prefix">On 14.03.2017 03:00, Reid Kleckner
wrote:<br>
</div>
<blockquote
cite="mid:CACs=tyJD0gvE=9wur0Y=K3knTTMudfcWwJDp9v9vAbdwGBwSmA@mail.gmail.com"
type="cite">
<div dir="ltr">Patch to catch this bug if you're curious: <a
moz-do-not-send="true" href="https://reviews.llvm.org/D30923"><a class="moz-txt-link-freetext" href="https://reviews.llvm.org/D30923">https://reviews.llvm.org/D30923</a></a></div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Mar 13, 2017 at 4:29 PM,
Vladimir Voskresensky via cfe-dev <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:cfe-dev@lists.llvm.org" target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><span class=""> <br>
<br>
<div class="m_1173606544579285353moz-cite-prefix">On
14.03.2017 00:33, Reid Kleckner via cfe-dev wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">I think this is something the compiler
should catch. I'm writing a generalized warning in
clang for it right now.</div>
</blockquote>
</span> Yes, I agree. In fact, this is how I got here
myself. I ran test <br>
<pre class="m_1173606544579285353diffs">${LLVM_SRC}/llvm/tools/clang/<wbr>test/Lexer/cxx1z-trigraphs.cpp</pre>
using Clank (the Java port of CLang)
<a moz-do-not-send="true" class="m_1173606544579285353moz-txt-link-freetext" href="https://eurollvm2017.sched.com/event/9wDw/clank-java-port-of-cc-compiler-frontend" target="_blank">https://eurollvm2017.sched.<wbr>com/event/9wDw/clank-java-<wbr>port-of-cc-compiler-frontend</a>
and got Java-assert that reducing from enumerator to 5 bits doesn't
fit for TST_error value :-)
Please, send me the changeset when you are done with compiler
warning.
Thanks!<span class="HOEnZb"><font color="#888888">
Vladimir.</font></span><div><div class="h5">
<blockquote type="cite">
<div class="gmail_extra">
<div class="gmail_quote">On Mon, Mar 13, 2017 at 12:57 PM,
Vladimir Voskresensky via cfe-dev <span dir="ltr"><<a moz-do-not-send="true" class="m_1173606544579285353moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span>
wrote:
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> Reid,
May be it's worth to have the same assert for
clang::DeclSpec::TypeSpecType?
Thanks,
Vladimir.
<div>
<div class="m_1173606544579285353h5">
<div class="m_1173606544579285353m_-153245685904042596moz-cite-prefix">On
13.03.2017 21:59, Reid Kleckner via cfe-dev wrote:
</div>
<blockquote type="cite">
<div dir="ltr">Thanks, fixed in r297654.</div>
<div class="gmail_extra">
<div class="gmail_quote">On Mon, Mar 13, 2017 at
10:35 AM, Vladimir Voskresensky via cfe-dev <span dir="ltr"><<a moz-do-not-send="true" class="m_1173606544579285353m_-153245685904042596moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span>
wrote:
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Clang
Developers,
in file clang/Basic/Specifiers.h there is
struct clang::WrittenBuiltinSpecs {
/*DeclSpec::TST*/ unsigned Type : 5; //
<< must be *6*
....
};
"Type" field must be 6 to match DeclSpec::TST
which is the same as enum TypeSpecifierType
which has
TST_error // erroneous type
with value 43 which can not be kept in 5 bits
field.
as a correct example you can see that
clang::DeclSpec::TypeSpecType field is 6 bits
So, we corrupt values during save in
clang::DeclSpec::SaveWrittenBu<wbr>iltinSpecs
for all after TST_image1d_t.
Btw, due to this TST_error is changed to
TST_float128....
Hope it helps,
Vladimir.
______________________________<wbr>_________________
cfe-dev mailing list
<a moz-do-not-send="true" href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>
<a moz-do-not-send="true" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a>
</blockquote>
</div>
</div>
<fieldset class="m_1173606544579285353m_-153245685904042596mimeAttachmentHeader"></fieldset>
<pre>______________________________<wbr>_________________
cfe-dev mailing list
<a moz-do-not-send="true" class="m_1173606544579285353m_-153245685904042596moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>
<a moz-do-not-send="true" class="m_1173606544579285353m_-153245685904042596moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
</div></div></div>
______________________________<wbr>_________________
cfe-dev mailing list
<a moz-do-not-send="true" href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>
<a moz-do-not-send="true" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a>
</blockquote></div>
</div>
<fieldset class="m_1173606544579285353mimeAttachmentHeader"></fieldset>
<pre>______________________________<wbr>_________________
cfe-dev mailing list
<a moz-do-not-send="true" class="m_1173606544579285353moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>
<a moz-do-not-send="true" class="m_1173606544579285353moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
</div></div></div>
______________________________<wbr>_________________
cfe-dev mailing list
<a moz-do-not-send="true" href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>
<a moz-do-not-send="true" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a>
</blockquote></div>
</div>
</blockquote>
</body></html>