<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Wed, Feb 15, 2017 at 10:02 AM FIXED-TERM Kammel Fabian (ETAS-PSC/EPE) <<a href="mailto:fixed-term.Fabian.Kammel@escrypt.com">fixed-term.Fabian.Kammel@escrypt.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">





<div lang="EN-US" link="blue" vlink="purple" class="gmail_msg">
<div class="m_7841001126532439234WordSection1 gmail_msg">
<p class="MsoNormal gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg">No sorry the error is on my side. I accidentally copied the same file twice. Find the correct files attached to this mail.
<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg">I do agree that the interface to the function calls can be improved, but (as you probably know) that is not always possible. I do have two weeks of spare time. Do you think it’s
 reasonable to implement a switch to specify this behavior as well? <u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg">Also do you think it’s possible to achieve this in two weeks? Sounds like this change/adding this option might be complex or even impossible?</span></p></div></div></blockquote><div><br></div><div>I don't think two weeks will be enough to come up with a solution that gets consensus; if not due to the work required, the latency alone will prevent this (I'd expect this to go through multiple possible architectural revisions)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple" class="gmail_msg"><div class="m_7841001126532439234WordSection1 gmail_msg"><p class="MsoNormal gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg">
<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg">Regards,
<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg">Fabian<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><b class="gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif" class="gmail_msg">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif" class="gmail_msg"> Manuel Klimek [mailto:<a href="mailto:klimek@google.com" class="gmail_msg" target="_blank">klimek@google.com</a>]
<br class="gmail_msg">
<b class="gmail_msg">Sent:</b> Dienstag, 14. Februar 2017 12:24<br class="gmail_msg">
<b class="gmail_msg">To:</b> FIXED-TERM Kammel Fabian (ETAS-PSC/EPE) <<a href="mailto:fixed-term.Fabian.Kammel@escrypt.com" class="gmail_msg" target="_blank">fixed-term.Fabian.Kammel@escrypt.com</a>>; <a href="mailto:cfe-dev@lists.llvm.org" class="gmail_msg" target="_blank">cfe-dev@lists.llvm.org</a><br class="gmail_msg">
<b class="gmail_msg">Subject:</b> Re: [cfe-dev] clang-format inconsistent behavior<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p></div></div><div lang="EN-US" link="blue" vlink="purple" class="gmail_msg"><div class="m_7841001126532439234WordSection1 gmail_msg">
<p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p>
<div class="gmail_msg">
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">Not sure whether I'm unable to use my mail program correctly, but I don't get a diff between desired.c and format_me.c.<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
<div class="gmail_msg">
<p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p>
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">Generally, we've thought about trying to make clang-format be more consistent across subsequent statements, but<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">a) that's a lot of effort, as clang-format fundamentally works on each statement separately<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">b) basically all instances (outside of braced lists, which have special support) we've seen have been due to code duplication, where the right answer is to refactor the code so the structure is simpler<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
<div class="gmail_msg">
<p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p>
</div>
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">For example, in your code, I would pull out a wrapper function that takes all the common parameters in a struct, and potentially the other parameters as structs, too. That way, the calls would become reasonably short.<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
<div class="gmail_msg">
<p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p>
</div>
</div>
</div>
<div class="gmail_msg">
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">On Mon, Feb 13, 2017 at 5:35 PM FIXED-TERM Kammel Fabian (ETAS-PSC/EPE) via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" class="gmail_msg" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm" class="gmail_msg">
<div class="gmail_msg">
<div class="gmail_msg">
<p class="MsoNormal gmail_msg"><span class="m_7841001126532439234gmailmsg gmail_msg"><span lang="DE" style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg">Hi All,
</span></span><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
<p class="MsoNormal gmail_msg"><span class="m_7841001126532439234gmailmsg gmail_msg"><span lang="DE" style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg"> </span></span><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
<p class="MsoNormal gmail_msg"><span class="m_7841001126532439234gmailmsg gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg">I have found an inconsistent behavior in clang-format. When I format the attached desired.c
 with the attached .clang-format file (using Clang 4.0 on Windows) I get format_me.c.</span></span><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
<p class="MsoNormal gmail_msg"><span class="m_7841001126532439234gmailmsg gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg"> </span></span><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
<p class="MsoNormal gmail_msg"><span class="m_7841001126532439234gmailmsg gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg">I think that the assignment should be consistent, either break the line for all assignments
 or none of them. Is there an option I have missed or is this behavior intended/not configurable? And if not configurable would we be interested in such a switch?</span></span><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
<p class="MsoNormal gmail_msg"><span class="m_7841001126532439234gmailmsg gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg"> </span></span><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
<p class="MsoNormal gmail_msg"><span class="m_7841001126532439234gmailmsg gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg">Regards,
</span></span><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
<p class="MsoNormal gmail_msg"><span class="m_7841001126532439234gmailmsg gmail_msg"><span style="font-size:10.0pt;font-family:"Arial",sans-serif" class="gmail_msg">Fabian</span></span><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
</div>
<p class="MsoNormal gmail_msg">_______________________________________________<br class="gmail_msg">
cfe-dev mailing list<br class="gmail_msg">
<a href="mailto:cfe-dev@lists.llvm.org" class="gmail_msg" target="_blank">cfe-dev@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</blockquote>
</div>
</div>
</div></div></blockquote></div></div>