<div dir="ltr">I've raised <a href="https://llvm.org/bugs/show_bug.cgi?id=31673">https://llvm.org/bugs/show_bug.cgi?id=31673</a> to track the version number check fix.<div><br></div><div>I think this should be merged to the 4.0 branch.</div><div><br></div><div>regards,</div><div><br></div><div>Jon</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 13 January 2017 at 16:38, Jonathan Coe <span dir="ltr"><<a href="mailto:jbcoe@me.com" target="_blank">jbcoe@me.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div> </div><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On 13 January 2017 at 15:37, Renato Golin <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="m_-2438457291674708421gmail-">On 13 January 2017 at 15:31, Jonathan Coe <<a href="mailto:jbcoe@me.com" target="_blank">jbcoe@me.com</a>> wrote:<br>
> Added <a href="https://llvm.org/bugs/show_bug.cgi?id=31628" rel="noreferrer" target="_blank">https://llvm.org/bugs/show_bug<wbr>.cgi?id=31628</a>.<br>
><br>
> Would be cool if you could sanity check it. I'm still new to this.<br>
<br>
</span>Sure! Please add the reviews to Phabricator<br>
(<a href="https://reviews.llvm.org/differential/" rel="noreferrer" target="_blank">https://reviews.llvm.org/diff<wbr>erential/</a>) and I'll review.<br>
<br></blockquote><div><br></div></span><div>I've reverted the problematic patch and added <a href="https://reviews.llvm.org/D28682" target="_blank">https://reviews.llvm.<wbr>org/D28682</a> to fix trivial language incompatibilities and fail if Python version !=2.<div><br></div><div>regards,</div><div><br></div><div>Jon</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
cheers,<br>
--renato<br>
</blockquote></div><br></div></div>
</blockquote></div><br></div>