<div dir="ltr">Thanks, r290979</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 3, 2017 at 10:57 AM, kyra <span dir="ltr"><<a href="mailto:kyrab@mail.ru" target="_blank">kyrab@mail.ru</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi, Reid,<br>
<br>
Thanks for being so responsive. I've attached the patch. It happens in a different place than MSVC's one, since the MSVC has it's own CLCompatOptions.td, which GNU driver doesn't have.<br>
<br>
Cheers, Kyra<br>
<br>
<br>
On 03.01.2017 20:24, Reid Kleckner wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
On Sun, Jan 1, 2017 at 11:35 PM, kyra via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a> <mailto:<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><wbr>>> wrote:<br>
<br>
3. I believe, we should pay more attention to support self-hosted<br>
mingw-w64 clang, I maintain a couple of patches which allow me to<br>
build it, but I never tried to publish them, because I saw no<br>
interest. Btw, that recent LLVM patch introducing big-obj switch<br>
(<a href="https://github.com/llvm-mirror/llvm/commit/e1c9f504c6810be782714b8b39f11579e50fa5c7" rel="noreferrer" target="_blank">https://github.com/llvm-mirro<wbr>r/llvm/commit/e1c9f504c6810be7<wbr>82714b8b39f11579e50fa5c7</a><br></span>
<<a href="https://github.com/llvm-mirror/llvm/commit/e1c9f504c6810be782714b8b39f11579e50fa5c7" rel="noreferrer" target="_blank">https://github.com/llvm-mirro<wbr>r/llvm/commit/e1c9f504c6810be7<wbr>82714b8b39f11579e50fa5c7</a>>)<span class=""><br>
also breaks self-hosted clang because gnu clang driver doesn't<br>
understand -Wa,-mbig-obj option. AFAIUI, LLVM handles COFF format<br>
automatically, selecting bigobj format if necessary, and msvc<br>
clang driver simply ignores '/bigobj' flag. I have a patch fixing<br>
gnu driver too.<br>
<br>
<br>
I'm happy to review these kinds of patches if you want to CC me on them. I don't have a lot of time to dedicate to mingw support in clang, so I mostly apply other people's patches and confirm that things seem to work.<br>
<br>
Accepting and ignoring the -mbig-obj flag in clang seems totally reasonable to me. Our assembler should implicitly do the right thing, as you described.<br>
</span></blockquote>
<br>
<br>
</blockquote></div><br></div>