<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2016-12-12 17:30 GMT+01:00 Gábor Horváth <span dir="ltr"><<a href="mailto:xazax.hun@gmail.com" target="_blank">xazax.hun@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><span class="gmail-"><div><br><div class="gmail_extra"><br><div class="gmail_quote">2016. dec. 12. du. 5:24 ezt írta ("Piotr Padlewski" <<a href="mailto:piotr.padlewski@gmail.com" target="_blank">piotr.padlewski@gmail.com</a>>):<br type="attribution"><blockquote class="gmail-m_-6036283529230895957quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">This sounds also good. I was thinking that it would be nice if clang-tidy itself could warn about old name and dump config, but problem here is<div>when user have configuration "misc-*" and we moved one check from misc to other group. We should probably dump clang-tidy version in the config to know how old is config.</div></div></blockquote></div></div></div><div dir="auto"><br></div></span><div dir="auto">That is a hairy problem. The reason why I do not like too many aliases, because it makes it harder to introduce clang tidy to a project. One have to go through more checkers. Also more work to set up the configuration files and check for inconsistencies (e.g.: same checker turned on using multiple names and inconsistent configuration options). </div><span class="gmail-"><div dir="auto"><br></div></span></div></blockquote><div>I understand your problem, but on the other hand I feel that most of the users don't want to enable whole google/llvm/cert/cppcoreguidelines group. Instead they want to pick "performance" or "readability" or "modernize". </div><div><br></div><div>Example:</div><div><ul style="padding-left:5px;margin-top:3px;color:rgb(51,51,51);font-family:"dejavu sans",arial,helvetica,sans-serif;font-size:14.4px"><li class="gmail-toctree-l1" style="line-height:1.3;background-image:url("bullet_orange.png");background-position:0% 0.45em;background-size:initial;background-repeat:no-repeat;background-origin:initial;background-clip:initial;background-color:transparent;list-style-type:none;padding:0px 0px 0px 1.666em;margin-bottom:3px"><br></li><li class="gmail-toctree-l1" style="line-height:1.3;background-image:url("bullet_orange.png");background-position:0% 0.45em;background-size:initial;background-repeat:no-repeat;background-origin:initial;background-clip:initial;background-color:transparent;list-style-type:none;padding:0px 0px 0px 1.666em;margin-bottom:3px">These checks could be moved into readability<a class="gmail-reference gmail-internal" href="http://clang.llvm.org/extra/clang-tidy/checks/llvm-header-guard.html" style="font-weight:bold;text-decoration:none;color:rgb(137,38,1)"><br class="gmail-Apple-interchange-newline">llvm-header-guard</a> </li><li class="gmail-toctree-l1" style="line-height:1.3;background-image:url("bullet_orange.png");background-position:0% 0.45em;background-size:initial;background-repeat:no-repeat;background-origin:initial;background-clip:initial;background-color:transparent;list-style-type:none;padding:0px 0px 0px 1.666em;margin-bottom:3px"><a class="gmail-reference gmail-internal" href="http://clang.llvm.org/extra/clang-tidy/checks/llvm-include-order.html" style="font-weight:bold;text-decoration:none;color:rgb(137,38,1)">llvm-include-order</a></li><li class="gmail-toctree-l1" style="line-height:1.3;background-image:url("bullet_orange.png");background-position:0% 0.45em;background-size:initial;background-repeat:no-repeat;background-origin:initial;background-clip:initial;background-color:transparent;list-style-type:none;padding:0px 0px 0px 1.666em;margin-bottom:3px"><a class="gmail-reference gmail-internal" href="http://clang.llvm.org/extra/clang-tidy/checks/llvm-namespace-comment.html" style="font-weight:bold;text-decoration:none;color:rgb(137,38,1)">llvm-namespace-comment</a></li><ul style="padding-left:5px;margin-top:3px"><li class="gmail-toctree-l2" style="line-height:1.3;background-image:url("bullet_orange.png");background-position:0% 0.45em;background-size:initial;background-repeat:no-repeat;background-origin:initial;background-clip:initial;background-color:transparent;list-style-type:none;padding:0px 0px 0px 1.666em;margin-bottom:3px"> </li><li class="gmail-toctree-l2" style="line-height:1.3;background-image:url("bullet_orange.png");background-position:0% 0.45em;background-size:initial;background-repeat:no-repeat;background-origin:initial;background-clip:initial;background-color:transparent;list-style-type:none;padding:0px 0px 0px 1.666em;margin-bottom:3px">This one could be general and take type name to look for - so we would have a link with configuration)</li></ul><li class="gmail-toctree-l1" style="line-height:1.3;background-image:url("bullet_orange.png");background-position:0% 0.45em;background-size:initial;background-repeat:no-repeat;background-origin:initial;background-clip:initial;background-color:transparent;list-style-type:none;padding:0px 0px 0px 1.666em;margin-bottom:3px"><a class="gmail-reference gmail-internal" href="http://clang.llvm.org/extra/clang-tidy/checks/llvm-twine-local.html" style="font-weight:bold;text-decoration:none;color:rgb(137,38,1)">llvm-twine-local</a></li></ul><div><font color="#333333" face="dejavu sans, arial, helvetica, sans-serif"><span style="font-size:14.4px">If clang-tidy would be smart enough to figure out that you are using the same check multiple times (e.g. after moving llvm checks to readability with -checks="llvm-*,readability-*") and merge your configuration somehow so you would run check only one time. </span></font></div></div><div><font color="#333333" face="dejavu sans, arial, helvetica, sans-serif"><span style="font-size:14.4px">If your configuration for both links is the same then it is obvious. If configuration would be different then </span></font></div><div><font color="#333333" face="dejavu sans, arial, helvetica, sans-serif"><span style="font-size:14.4px">a) there is bug in configuration and user have to pick only one option</span></font></div><div><font color="#333333" face="dejavu sans, arial, helvetica, sans-serif"><span style="font-size:14.4px">b) options have to be merged to look for more things (e.g. llvm-twine-local would look for stack variable with type "twine" and orgname-different_type-local would look for type "different_type". Both would use the same check so we could just merge and look for "twine;different_type"</span></font></div><div><font color="#333333" face="dejavu sans, arial, helvetica, sans-serif"><span style="font-size:14.4px"><br></span></font></div><div><font color="#333333" face="dejavu sans, arial, helvetica, sans-serif"><span style="font-size:14.4px">Piotr</span></font></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><span class="gmail-"><div dir="auto"></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail-m_-6036283529230895957quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail-m_-6036283529230895957elided-text"><div class="gmail_extra"><br><div class="gmail_quote">2016-12-12 16:17 GMT+01:00 Gábor Horváth <span dir="ltr"><<a href="mailto:xazax.hun@gmail.com" target="_blank">xazax.hun@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div>Hi!<br><br></div>What about an alternative solution, like changing the names and providing a python script to migrate the configuration files?<br><br></div>Regards,<br></div>Gábor<br></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="gmail-m_-6036283529230895957m_8708935457173321864h5">On 12 December 2016 at 16:02, Piotr Padlewski via cfe-dev <span dir="ltr"><<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="gmail-m_-6036283529230895957m_8708935457173321864h5"><div dir="ltr">Hi,<div>as clang-tidy grows there are more and more checks. One of the problem I see is that "misc" check group is not user friendly - there are many checks that do so many different things that usually user don't want to enable whole group.</div><div>Other groups like modernize, performance, google, cert, boost, llvm doesn't have this problem. Naturally the solution would be to split the group into smaller groups that would mean more. </div><div>The problem is that we should not change names because old configs will not work.</div><div><br></div><div>Do you have some ideas how we could fix it, so we could make it easier for users to use it?</div><div><br></div><div>Other feature that we could add if we would know how to solve it is that we could make new groups that would mostly have aliases to other checks. This might be specially useful for cert checks - the cert code names doesn't tell anything, so it would be good to have these checks with proper name in different group so normal user could see what this check is doing from name and CERT users could run checks with cert group as it was before.</div><div><br></div><div><br></div><div>One solution that I see is to reserve old name and make redirection, and maybe output warning about deprecated name when user would use special flag (e.g. verbose)</div><div><br></div><div>What do you think about this problem?</div><span class="gmail-m_-6036283529230895957m_8708935457173321864m_-7543205314633514350HOEnZb"><font color="#888888"><div><br></div><div>Piotr</div><div><br></div></font></span></div>
<br></div></div>______________________________<wbr>_________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>
</div></blockquote></div><br></div></div></span></div>
</blockquote></div><br></div></div>