<div dir="ltr">There's two suggestions for warnings here:<div>1) Warn that pointer p is given a pointer from somewhere and then dereferenced without a null check.</div><div>2) Warn that two similar constructions only differing by pointer versus reference, and should suggest the appropriate constructor.</div><div><br></div><div>1 is hard because the assignment and dereference can be separated by some amount of intervening code that needs to be checked. This requires at least a path-sensitive checker. There's also the case that the check is performed by a different function, which further complicates the checking. Also, getFooL() may have guarantees not visible to Clang. If it already returns a non-null pointer, then this warning would be a false positive.</div><div><br></div><div>2 requires the comparison of the structure of functions to determine that they are identical except for the pointer/reference difference. That would be a very fragile check and even small changes to the constructors would render Clang unable to see the equivalence between the two functions.</div><div><br></div><div>As you've noted, Clang does have specific warnings for very obvious and very simple cases. More complicated cases involving examining code across different functions is difficult and time-consuming for Clang, if not impossible if the functions are across different translation units. If you are concerned about this problem in the future, I recommend the dynamic analysis tool Undefined Behavior Sanitizer (<a href="http://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html" target="_blank">http://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html</a>). Using the null checker will allow you to catch the null dereference at runtime.</div><div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 21, 2016 at 10:28 PM, Riyaz Puthiyapurayil via cfe-dev <span dir="ltr"><<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div>
<p>[corrected some typos in the earlier email]<u></u><u></u></p><span>
<p><u></u> <u></u></p>
<p>We have some very old code that resembles the following that causes it to crash when compiled with clang (it “works” with gcc). The problem is the dereference of ‘p’ in the constructor argument of fooLI below (line marked as [2]). Due
to this dereference, the constructor FooLI(const Foo<T>& foo) is invoked which in turn invokes FooBI(…). Since p has already been dereferenced, clang assumes that p is non-null (which is OK because well-formed C++ code would not dereference a NULL pointer).
Clang therefore eliminates the null check on foo_ at line [1] assuming that it always non-NULL. So when a null pointer is returned by getFooL(), a crash occurs.<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>class FooBI {<u></u><u></u></p>
</span><p>public:<u></u><u></u></p>
<p> :<u></u><u></u></p><span>
<p> FooBI(const FooB* foo_) :<u></u><u></u></p>
<p> foo(foo_ && foo_->bar ? foo_ : NULL) {} // [1]<u></u><u></u></p>
<p> :<u></u><u></u></p>
<p>};<u></u><u></u></p>
</span><p>template<class T>class FooLI : public FooBI {<u></u><u></u></p>
<p>public:<u></u><u></u></p><span>
<p> : <u></u><u></u></p>
<p> FooLI(const FooL<T>* foo) :<u></u><u></u></p>
<p> FooBI(foo)<u></u><u></u></p>
<p> {}<u></u><u></u></p>
<p> FooLI(const Foo<T>& foo) :<u></u><u></u></p>
<p> FooBI(&foo)<u></u><u></u></p>
<p> {}<u></u><u></u></p>
<p> :<u></u><u></u></p>
<p>};<u></u><u></u></p>
<p>:<u></u><u></u></p>
<p> FooL<Boo>* p = getFooL(); <u></u><u></u></p>
<p> FooLI fooLI = FooLI(*p); // [2] p can be sometimes NULL <u></u>
<u></u></p>
<p><u></u> <u></u></p>
</span><p>The fix for this problem in our code is to avoid the dereference on line [2] which will then invoke FooLI(const FooL<T>* foo) and the null check on line [1] will be retained. Is it possible for clang to generate a warning about this? -Wundefined-bool-conversion
does generate warnings in similar situations but not specifically for this case. Perhaps, this should be a different warning. There are two choices of constructors, one accepting a pointer and another accepting a reference. When the pointer is then dereferenced
and converted to a reference, do you think it merits a warning?<u></u><u></u></p>
<p><u></u> <u></u></p>
<p><u></u> <u></u></p>
</div>
</div>
<br>_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div><br></div></div></div>