<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">We still turn off, and have always turned off, the _LIBCPP_TRIVIAL_PAIR_COPY_CTOR option in FreeBSD, since we are supposed to be backwards compatible with previous versions of libc++ that we shipped; see <a href="https://svnweb.freebsd.org/base/head/contrib/libc++/include/__config?view=markup#l733" class="">https://svnweb.freebsd.org/base/head/contrib/libc++/include/__config?view=markup#l733</a></div><div class=""><br class=""></div><div class="">If the option is completely removed, we will either have to supply two versions of libc++, or bolt on some sort of backwards compatibility versioned symbols. Alternatively, we can add a local hack to put back the non-trivial copy constructor, but that might lead to other headaches.</div><div class=""><br class=""></div><div class="">David, do you have any good ideas for this? I think your idea was to burn all backwards compatibility bridges, but we can't really do that for FreeBSD 11.0 at this point, so we would have to start backporting fixes from trunk libc++, instead of importing it wholesale. For FreeBSD 12.0 we could ship only the new libc++, and provide the older libc++ as a compatibility package.</div><div class=""><br class=""></div><div class="">-Dimitry</div><br class=""><div><blockquote type="cite" class=""><div class="">On 14 Jun 2016, at 03:44, Eric Fiselier via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I have removed this option from in the libc++ in r272613. I believe it has no clients.<div class="">If anybody uses this option please contact me.<br class=""><div class=""><br class=""></div><div class="">This option was used to turn off std::pair's trivial copy constructor, instead selecting an older non-trivial implementation.<br class=""><div class=""><br class=""></div><div class="">It was added in r194742, on November 14th 2013. At that time Apple platforms used this option to turn off pairs trivial constructor. Two weeks later, on November 26th 2013, the default value for Apple platforms was removed in r195796.</div></div><div class=""><br class=""></div><div class="">Defining `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR` will now cause an explicit error informing the client that the option has been removed. I will remove this diagnostic after the 3.9 release.</div><div class=""><br class=""></div><div class="">/Eric</div><div class=""><br class=""></div><div class=""><br class=""></div></div></div>
_______________________________________________<br class="">cfe-dev mailing list<br class=""><a href="mailto:cfe-dev@lists.llvm.org" class="">cfe-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev<br class=""></div></blockquote></div><br class=""></body></html>